Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 5, 2025

Fixed "Can not import server (async) components in client components" error


PR-Codex overview

This PR focuses on refactoring and organizing wallet, NFT, token, and account previews by creating dedicated preview components. This enhances code readability and reusability.

Detailed summary

  • Added new preview components for wallets: WalletIconBasicPreview, WalletNameBasicPreview, WalletNameFormatPreview.
  • Created NFT preview components: NftMediaBasicPreview, NftMediaOverridePreview, NftNameBasicPreview, NftDescriptionBasicPreview, NftCardDemoPreview.
  • Introduced token preview components: TokenImageBasicPreview, TokenImageOverridePreview, TokenNameBasicPreview, TokenSymbolBasicPreview, TokenCardPreview.
  • Established account preview components: AccountAddressBasicPreview, AccountAddressFormatPreview, AccountNameBasicPreview, AccountNameCustomPreview, AccountBalanceBasicPreview, AccountBalanceCustomTokenPreview, AccountBalanceFormatPreview, AccountBalanceUSDPreview, AccountAvatarBasicPreview, AccountBlobbieBasicPreview, ConnectDetailsButtonClonePreview.
  • Updated example components to use the new preview components for better organization and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 6d3947a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 5, 2025
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 8:12pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 6, 2025 8:12pm
login ⬜️ Skipped (Inspect) Feb 6, 2025 8:12pm
thirdweb-www ⬜️ Skipped (Inspect) Feb 6, 2025 8:12pm
wallet-ui ⬜️ Skipped (Inspect) Feb 6, 2025 8:12pm

@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 16:31 Inactive
@MananTank MananTank marked this pull request as ready for review February 5, 2025 16:31
@MananTank MananTank requested review from a team as code owners February 5, 2025 16:31
Copy link
Member Author

MananTank commented Feb 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.91%. Comparing base (632f1d1) to head (6d3947a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6175   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files        1155     1155           
  Lines       63912    63912           
  Branches     5195     5195           
=======================================
  Hits        36378    36378           
  Misses      26807    26807           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 632f1d1
packages 55.12% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 301 ms (+36.64% 🔺) 1.3 s
thirdweb (cjs) 122.56 KB (0%) 2.5 s (0%) 753 ms (+10.58% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 167 ms (+375.51% 🔺) 278 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 20 ms (+35.39% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 58 ms (-32.16% 🔽) 444 ms

@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 2987f81 to 9e60b66 Compare February 5, 2025 16:35
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 16:35 Inactive
@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 9e60b66 to 296a627 Compare February 5, 2025 16:39
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2025

Merge activity

…es (#6175)

Fixed "Can not import server (async) components in client components" error

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces new preview components for wallet, NFT, token, and account functionalities in the `playground-web` application. It enhances code modularity by separating previews into distinct files, improving readability and maintainability.

### Detailed summary
- Added `wallet-previews.tsx` with previews for `WalletIcon`, `WalletName`, and formatting options.
- Created `nft-previews.tsx` with previews for `NFTMedia`, `NFTName`, and `NFTDescription`.
- Introduced `token-previews.tsx` with previews for `TokenIcon`, `TokenName`, and `TokenSymbol`.
- Developed `account-previews.tsx` for `AccountAddress`, `AccountName`, and `AccountBalance` with various configurations.
- Updated example files (`wallet-examples.tsx`, `nft-examples.tsx`, `token-examples.tsx`, `account-examples.tsx`) to utilize new preview components, enhancing code clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 02-05-_tool-3299_playground_update_sidebar_minor_improvements_and_fixes branch from ded18b3 to 632f1d1 Compare February 6, 2025 20:10
@graphite-app graphite-app bot force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from b6207a6 to 6d3947a Compare February 6, 2025 20:11
Base automatically changed from 02-05-_tool-3299_playground_update_sidebar_minor_improvements_and_fixes to main February 6, 2025 20:13
@graphite-app graphite-app bot merged commit 6d3947a into main Feb 6, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch February 6, 2025 20:14
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 6, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 6, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 6, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Production – login February 6, 2025 20:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants