Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 7, 2025

PR-Codex overview

This PR introduces a set of enhancements and features related to the Nebula analytics functionality, including new components, improved data fetching, and UI updates, particularly around handling search parameters and displaying analytics data.

Detailed summary

  • Added getNebulaAnalyticsRangeFromSearchParams function in utils.ts.
  • Removed isOnNebulaWaitList prop from ProjectTabs.
  • Enhanced DatePickerWithRange to accept popoverAlign.
  • Implemented fetchNebulaAnalytics function in fetch-nebula-analytics.tsx.
  • Introduced normalizeTime utility in time.ts.
  • Created NebulaAnalyticsFilter component for filtering analytics data.
  • Updated NebulaAnalyticsPage to handle authentication and data fetching.
  • Added NebulaAnalyticsDashboardUI for displaying analytics data with charts.
  • Introduced storybook entries for NebulaAnalyticsDashboardUI.
  • Improved DateRangeSelector to normalize date handling and popover alignment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 7, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 815b9b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:08pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:08pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:08pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:08pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:08pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 7, 2025 19:50
@MananTank MananTank requested review from a team as code owners February 7, 2025 19:50
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.73%. Comparing base (92266b7) to head (815b9b1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6198   +/-   ##
=======================================
  Coverage   56.72%   56.73%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5198    +2     
=======================================
+ Hits        36468    36474    +6     
+ Misses      27095    27087    -8     
- Partials      726      728    +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 92266b7
packages 54.91% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 6 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 299 ms (+129.19% 🔺) 1.3 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 401 ms (+3.88% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 54 ms (+435.83% 🔺) 166 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 50 ms (+531.5% 🔺) 60 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 59 ms (+55.04% 🔺) 445 ms

@socket-security
Copy link

socket-security bot commented Feb 10, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/responsive-rsc@0.0.7 None 0 71.9 kB manantank

View full report↗︎

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR primarily focuses on enhancing the `Nebula` analytics functionality by adding new components and improving data handling for analytics. It introduces new utilities for managing date ranges and search parameters, along with updates to the UI for better user interaction.

### Detailed summary
- Added `getNebulaAnalyticsRangeFromSearchParams` function in `utils.ts`.
- Updated `ProjectTabs` to remove `isOnNebulaWaitList` prop.
- Introduced `normalizeTime` function in `time.ts` for date normalization.
- Created `NebulaAnalyticsFilter` component for filtering analytics data.
- Implemented `NebulaAnalyticsPage` and `NebulaAnalyticDashboard` for displaying analytics.
- Enhanced `DateRangeSelector` with popover alignment options.
- Added `NebulaAnalyticsDashboardUI` for rendering analytics data and charts.
- Integrated `responsive-rsc` for responsive search parameters.
- Updated `package.json` to include `responsive-rsc` dependency.
- Removed calls to `getTeamNebulaWaitList` in `layout.tsx` and associated logic.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants