Docs remove legacy enc key arg #6220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Portal
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
0xFirekeeper
added
merge-queue
Member
Author
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6220 +/- ##
==========================================
- Coverage 56.76% 56.72% -0.05%
==========================================
Files 1161 1161
Lines 64261 64289 +28
Branches 5197 5196 -1
==========================================
- Hits 36479 36468 -11
- Misses 27053 27095 +42
+ Partials 729 726 -3
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Feb 10, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Closes TOOL-3348
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on simplifying the instantiation of the `InAppWalletOptions` by removing the `encryptionKey` parameter from its constructor calls.
### Detailed summary
- Removed `encryptionKey: "myencryptionkey"` from the first instance of `InAppWalletOptions`.
- Removed `-encryptionKey: "myencryptionkey"` from the second instance of `InAppWalletOptions`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
firekeeper/remove-enc-key
branch
from
d32e1a5 to
bbcbd59
Compare
Closes TOOL-3348
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on simplifying the initialization of `InAppWalletOptions` by removing the `encryptionKey` parameter and its usage in two instances.
### Detailed summary
- Removed `encryptionKey` from the instantiation of `InAppWalletOptions` in two locations.
- Retained the `jwtOrPayload` parameter in both instances.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
firekeeper/remove-enc-key
branch
from
bbcbd59 to
e9d54fc
Compare
graphite-app
bot
removed
the
merge-queue
graphite-app
bot
removed
the
hotfix
joaquim-verges
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TOOL-3348
PR-Codex overview
This PR focuses on modifying the initialization of
InAppWalletOptionsby removing theencryptionKeyparameter from its constructor, simplifying its instantiation.Detailed summary
encryptionKey: "myencryptionkey"from the initialization ofinAppWalletOptions.InAppWalletOptionsconstructor now only includesauthproviderandjwtOrPayload.