Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 10, 2025

PR-Codex overview

This PR focuses on modifying the logic for handling the publishedContract in the page.tsx file. It removes the condition that triggers notFound() when publishedContract is falsy and instead continues processing if it exists.

Detailed summary

  • Removed the check for !publishedContract that called notFound().
  • Retained the processing of publishedContract when it is truthy.
  • Ensured that publishMetadata is populated with the properties of publishedContract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 10, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 80ad84b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 5:04pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 10, 2025 5:04pm
login ⬜️ Skipped (Inspect) Feb 10, 2025 5:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 10, 2025 5:04pm
wallet-ui ⬜️ Skipped (Inspect) Feb 10, 2025 5:04pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 16:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 16:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 16:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 16:54 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 10, 2025 16:54
@MananTank MananTank requested review from a team as code owners February 10, 2025 16:54
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Feb 10, 2025 — with Graphite App
Copy link
Member Author

MananTank commented Feb 10, 2025

Merge activity

  • Feb 10, 11:56 AM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 12:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 12:05 PM EST: A user merged this pull request with the Graphite merge queue.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (633f0ca) to head (80ad84b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6221   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 633f0ca
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 506 ms (+89.59% 🔺) 1.5 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 913 ms (+11.91% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 88 ms (+110.07% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 72 ms (+765.54% 🔺) 82 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 239 ms (+158.75% 🔺) 625 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 17:02 Inactive
@graphite-app graphite-app bot merged commit 80ad84b into main Feb 10, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3376 branch February 10, 2025 17:05
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 10, 2025 17:05 Inactive
@vercel vercel bot temporarily deployed to Production – login February 10, 2025 17:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants