Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 10, 2025

TOOL-0000


PR-Codex overview

This PR introduces a new supportPlan property and updates related logic to accommodate it in the dashboard application. It ensures that the supportPlan is treated similarly to the existing billingPlan, affecting how customer IDs are determined.

Detailed summary

  • Added supportPlan property to the stubs.ts file.
  • Updated team.ts to include supportPlan in the type definitions.
  • Changed logic in create-ticket.action.ts to derive customerId from supportPlan instead of billingPlan, with a fallback to the "free" tier.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 22:20 Inactive
@vercel
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 3:55am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 11, 2025 3:55am
login ⬜️ Skipped (Inspect) Feb 11, 2025 3:55am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 11, 2025 3:55am
wallet-ui ⬜️ Skipped (Inspect) Feb 11, 2025 3:55am

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: a43bd39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 10, 2025
@jnsdls jnsdls marked this pull request as ready for review February 10, 2025 22:20
Copy link
Member Author

jnsdls commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls requested review from a team as code owners February 10, 2025 22:20
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 10, 2025 — with Graphite App
@jnsdls jnsdls changed the base branch from _TOOL-3379_Dashboard_Add_Team_selector_in_support_form_send_teamId_to_unthread_API to graphite-base/6228 February 10, 2025 22:21
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (cf53184) to head (a43bd39).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6228      +/-   ##
==========================================
+ Coverage   56.73%   56.81%   +0.08%     
==========================================
  Files        1161     1163       +2     
  Lines       64289    64342      +53     
  Branches     5198     5213      +15     
==========================================
+ Hits        36474    36556      +82     
+ Misses      27087    27057      -30     
- Partials      728      729       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cf53184
packages 55.01% <ø> (+0.09%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 11 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 286 ms (+44.18% 🔺) 1.3 s
thirdweb (cjs) 121.86 KB (0%) 2.5 s (0%) 447 ms (-13.48% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 80 ms (+448.39% 🔺) 192 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (-17.23% 🔽) 23 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 94 ms (+125.53% 🔺) 480 ms

@jnsdls jnsdls force-pushed the graphite-base/6228 branch from 0fca96a to cf53184 Compare February 10, 2025 22:24
@jnsdls jnsdls force-pushed the use_supportPlan_instead_of_billingPlan_for_support_tickets branch from c4b9385 to 4c223f9 Compare February 10, 2025 22:24
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 22:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 22:24 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 22:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 22:24 Inactive
@jnsdls jnsdls changed the base branch from graphite-base/6228 to main February 10, 2025 22:25
@jnsdls jnsdls force-pushed the use_supportPlan_instead_of_billingPlan_for_support_tickets branch from 4c223f9 to cfce785 Compare February 10, 2025 22:25
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 10, 2025 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 22:25 Inactive
@jnsdls jnsdls force-pushed the use_supportPlan_instead_of_billingPlan_for_support_tickets branch from cfce785 to 31ac533 Compare February 11, 2025 03:30
@vercel vercel bot temporarily deployed to Preview – login February 11, 2025 03:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 11, 2025 03:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 11, 2025 03:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 11, 2025 03:31 Inactive
@jnsdls jnsdls force-pushed the use_supportPlan_instead_of_billingPlan_for_support_tickets branch from 31ac533 to a43bd39 Compare February 11, 2025 03:45
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 11, 2025 03:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 11, 2025 03:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 11, 2025 03:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 11, 2025 03:45 Inactive
@jnsdls jnsdls merged commit dfbdbd0 into main Feb 11, 2025
35 of 36 checks passed
@jnsdls jnsdls deleted the use_supportPlan_instead_of_billingPlan_for_support_tickets branch February 11, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants