Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 13, 2025

PR-Codex overview

This PR focuses on enhancing the Pay components by transitioning from using clientId to a more structured approach that includes projectId and teamId, marking clientId as deprecated during the migration.

Detailed summary

  • Updated page.tsx and webhooks/page.tsx to include projectId and teamId.
  • Added projectId and teamId to multiple components: TotalVolumePieChart, Payouts, PayCustomersTable, TotalPayVolume, PaymentsSuccessRate, PayNewCustomers, and PaymentHistory.
  • Marked clientId as deprecated in all related components.
  • Adjusted hooks: usePayCustomers, usePayPurchases, usePayVolume, and usePayNewCustomers to accept projectId and teamId.
  • Updated PayWebhooksPage to incorporate projectId and teamId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: cddbc23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

jnsdls commented Feb 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 13, 2025
@jnsdls jnsdls marked this pull request as ready for review February 13, 2025 01:17
@jnsdls jnsdls requested review from a team as code owners February 13, 2025 01:17
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (880148b) to head (cddbc23).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6245      +/-   ##
==========================================
- Coverage   56.87%   56.86%   -0.01%     
==========================================
  Files        1166     1166              
  Lines       64522    64523       +1     
  Branches     5223     5226       +3     
==========================================
- Hits        36699    36694       -5     
- Misses      27095    27101       +6     
  Partials      728      728              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 880148b
packages 55.08% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:39am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 13, 2025 5:39am
login ⬜️ Skipped (Inspect) Feb 13, 2025 5:39am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 13, 2025 5:39am
wallet-ui ⬜️ Skipped (Inspect) Feb 13, 2025 5:39am

@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 01:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 01:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 01:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 01:20 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.7 s (-8.05% 🔽) 3.6 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 6.1 s (+18.54% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 744 ms (+296.32% 🔺) 856 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 129 ms (+76.86% 🔺) 139 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 508 ms (-18.61% 🔽) 894 ms

@jnsdls jnsdls force-pushed the add_projectId_parameter_to_pay_analytics_components branch from 5694742 to cabc1b9 Compare February 13, 2025 01:38
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 01:38 Inactive
@jnsdls jnsdls force-pushed the add_projectId_parameter_to_pay_analytics_components branch from cabc1b9 to f99de5a Compare February 13, 2025 04:10
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 04:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 04:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 04:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 04:10 Inactive
@jnsdls jnsdls force-pushed the add_projectId_parameter_to_pay_analytics_components branch from f99de5a to cddbc23 Compare February 13, 2025 05:31
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 05:31 Inactive
@jnsdls jnsdls merged commit b7158c2 into main Feb 13, 2025
33 of 34 checks passed
@jnsdls jnsdls deleted the add_projectId_parameter_to_pay_analytics_components branch February 13, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants