-
Notifications
You must be signed in to change notification settings - Fork 619
[NEB-95] Dashboard: Nebula Analytics UI updates #6248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
=======================================
Coverage 56.86% 56.86%
=======================================
Files 1166 1166
Lines 64523 64523
Branches 5226 5226
=======================================
Hits 36694 36694
Misses 27101 27101
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
...[team_slug]/(team)/~/engine/(instance)/[engineId]/overview/components/transactions-table.tsx
Show resolved
Hide resolved
Merge activity
|
 <!-- start pr-codex --> ## PR-Codex overview This PR primarily focuses on enhancing the `ThirdwebBarChart` and `ThirdwebAreaChart` components by introducing a `header` prop for improved chart display, modifying chart aspect ratios, and refining random data generation for analytics. It also updates the `NebulaAnalyticsPage` structure. ### Detailed summary - Added `header` prop to `ThirdwebBarChart` and `ThirdwebAreaChart` for titles and descriptions. - Changed aspect ratio from `lg:aspect-[4.5]` to `lg:aspect-[3.5]` in `Analytics.tsx`. - Updated import path for `NebulaAnalyticsPage`. - Refined random data generation logic in `nebula-analytics-ui.stories.tsx`. - Improved chart configurations in multiple analytics components. - Introduced `AnalyticsChart` component for better organization of chart data and props. - Adjusted styling and structure of various charts for consistency. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
f638967 to
3ff8c3f
Compare

PR-Codex overview
This PR focuses on enhancing the
ThirdwebBarChartandThirdwebAreaChartcomponents by introducing aheaderprop for better customization. It also updates various components to utilize this new prop and improves random data generation for analytics.Detailed summary
ThirdwebBarChartto include aheaderprop for title and description.ThirdwebAreaChartto include aheaderprop.Analytics.tsxandtransactions-table.tsx.NebulaAnalyticsPageimport path for clarity.ContractAnalyticsPage.tsxto use the newheaderprop.