Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 13, 2025

PR-Codex overview

This PR focuses on updating the dynamic export in two files to ensure consistent behavior in the application.

Detailed summary

  • Removed the export const dynamic = "force-static"; line from apps/dashboard/src/app/(dashboard)/explore/page.tsx.
  • Removed the export const dynamic = "force-static"; line from apps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 13, 2025

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 3:15pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 13, 2025 3:15pm
login ⬜️ Skipped (Inspect) Feb 13, 2025 3:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 13, 2025 3:15pm
wallet-ui ⬜️ Skipped (Inspect) Feb 13, 2025 3:15pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 15:05 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 13, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 13, 2025 15:05
@MananTank MananTank requested review from a team as code owners February 13, 2025 15:05
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Feb 13, 2025 — with Graphite App
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (b7158c2) to head (4bd03b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6250   +/-   ##
=======================================
  Coverage   56.86%   56.86%           
=======================================
  Files        1166     1166           
  Lines       64523    64523           
  Branches     5226     5226           
=======================================
  Hits        36694    36694           
  Misses      27101    27101           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b7158c2
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 3.6 s (+19.55% 🔺) 4.5 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 6.2 s (+4.38% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 324 ms (+13.16% 🔺) 435 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 61 ms (+28.72% 🔺) 71 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 1.2 s (+35.52% 🔺) 1.6 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 13, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-13-_tool-3415_dashboard_fix_explore_page_header_showing_logged_out_state branch from 0d4d0f4 to 4bd03b0 Compare February 13, 2025 15:12
@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 4bd03b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 15:13 Inactive
@graphite-app graphite-app bot merged commit 4bd03b0 into main Feb 13, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 02-13-_tool-3415_dashboard_fix_explore_page_header_showing_logged_out_state branch February 13, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants