Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 13, 2025


PR-Codex overview

This PR adds functionality to handle searchParams in the Page component, allowing for redirection based on the presence of an importUrl.

Detailed summary

  • Added searchParams to the Page function's props.
  • Used Promise.all to await both params and searchParams.
  • Implemented a conditional redirect if searchParams.importUrl is present, directing to the import URL.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 13, 2025

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:48pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 13, 2025 11:48pm
login ⬜️ Skipped (Inspect) Feb 13, 2025 11:48pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 13, 2025 11:48pm
wallet-ui ⬜️ Skipped (Inspect) Feb 13, 2025 11:48pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 0c5a51c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 20:36 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 13, 2025
@MananTank MananTank marked this pull request as ready for review February 13, 2025 20:36
@MananTank MananTank requested review from a team as code owners February 13, 2025 20:36
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (90428b4) to head (0c5a51c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6254   +/-   ##
=======================================
  Coverage   56.86%   56.86%           
=======================================
  Files        1166     1166           
  Lines       64523    64523           
  Branches     5226     5226           
=======================================
  Hits        36694    36694           
  Misses      27101    27101           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 90428b4
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.1 s (-39.6% 🔽) 3 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 6.1 s (+8% 🔺) 8.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 265 ms (-2.93% 🔽) 377 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 149 ms (+125.18% 🔺) 159 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 728 ms (-12.6% 🔽) 1.2 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 13, 2025

Merge activity

#6254)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `Page` function in `page.tsx` to handle `searchParams`, allowing for an import URL to trigger a redirect when present.

### Detailed summary
- Added `searchParams` to the `Page` function's props.
- Used `Promise.all` to await both `params` and `searchParams`.
- Implemented a redirect to an import URL if `searchParams.importUrl` is provided.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 23:46 Inactive
@graphite-app graphite-app bot merged commit 0c5a51c into main Feb 13, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3243 branch February 13, 2025 23:49
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 13, 2025 23:49 Inactive
@vercel vercel bot temporarily deployed to Production – login February 13, 2025 23:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants