-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-3243] Dashboard: Add redirect for support old engine import link #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
apps/dashboard/src/app/team/[team_slug]/(team)/~/engine/(general)/page.tsx
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
=======================================
Coverage 56.86% 56.86%
=======================================
Files 1166 1166
Lines 64523 64523
Branches 5226 5226
=======================================
Hits 36694 36694
Misses 27101 27101
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
#6254) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `Page` function in `page.tsx` to handle `searchParams`, allowing for an import URL to trigger a redirect when present. ### Detailed summary - Added `searchParams` to the `Page` function's props. - Used `Promise.all` to await both `params` and `searchParams`. - Implemented a redirect to an import URL if `searchParams.importUrl` is provided. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
83ac8ca to
0c5a51c
Compare

PR-Codex overview
This PR adds functionality to handle
searchParamsin thePagecomponent, allowing for redirection based on the presence of animportUrl.Detailed summary
searchParamsto thePagefunction's props.Promise.allto await bothparamsandsearchParams.searchParams.importUrlis present, directing to the import URL.