Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 14, 2025

TL;DR

Added teamId parameter to webhook creation and deletion API calls.

What changed?

  • Added teamId to the request payload when creating new webhooks
  • Added teamId to the request payload when deleting existing webhooks

How to test?

  1. Navigate to the webhooks page for a project
  2. Create a new webhook and verify it succeeds
  3. Delete an existing webhook and verify it succeeds
  4. Check server logs to confirm teamId is being received correctly

Why make this change?

The teamId parameter is required for proper webhook management and authorization at the team level. This ensures webhooks are properly scoped to the correct team context.

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 14, 2025 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 14, 2025 15:47 Inactive
@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:54pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 14, 2025 3:54pm
login ⬜️ Skipped (Inspect) Feb 14, 2025 3:54pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 14, 2025 3:54pm
wallet-ui ⬜️ Skipped (Inspect) Feb 14, 2025 3:54pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 14, 2025 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 14, 2025 15:47 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 711af54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls marked this pull request as ready for review February 14, 2025 15:47
@jnsdls jnsdls requested review from a team as code owners February 14, 2025 15:47
Copy link
Member Author

jnsdls commented Feb 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 14, 2025
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.85%. Comparing base (e201e3d) to head (711af54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6260   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files        1166     1166           
  Lines       64526    64526           
  Branches     5223     5223           
=======================================
  Hits        36686    36686           
  Misses      27115    27115           
  Partials      725      725           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e201e3d
packages 55.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@jnsdls jnsdls merged commit 06d6504 into main Feb 14, 2025
33 of 39 checks passed
@jnsdls jnsdls deleted the add_teamId_parameter_to_webhook_endpoints branch February 14, 2025 15:48
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 331 ms (+52.39% 🔺) 1.3 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 525 ms (-2.49% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+64.16% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+81.53% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 87 ms (+13.6% 🔺) 473 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants