You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces support for fetching NFTs by their index in ERC721Enumerable contracts. It adds a tokenByIndex option in various files to enable this functionality, enhancing the NFT retrieval process.
Detailed summary
Added isTokenByIndexSupported export in erc721.ts.
Introduced tokenByIndex option in getNFTs.ts and getNFT.ts.
Updated TokenIdPage to include tokenByIndex flag.
Enhanced ContractNFTPage to pass tokenByIndex to NFTGetAllTable.
Modified NFTGetAllTable to handle tokenByIndex prop and adjust token ID display.
Implemented logic in getNFT to fetch token ID by index if tokenByIndex is true.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
DashboardInvolves changes to the Dashboard.hotfixThis pull request should be prioritized in the merge queue.packagesSDKInvolves changes to the thirdweb SDK
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
Dashboard
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kumaryash90
added
the
hotfix
TOOL-3515
PR-Codex overview
This PR introduces support for fetching NFTs by their index in ERC721Enumerable contracts. It adds a
tokenByIndexoption in various files to enable this functionality, enhancing the NFT retrieval process.Detailed summary
isTokenByIndexSupportedexport inerc721.ts.tokenByIndexoption ingetNFTs.tsandgetNFT.ts.TokenIdPageto includetokenByIndexflag.ContractNFTPageto passtokenByIndextoNFTGetAllTable.NFTGetAllTableto handletokenByIndexprop and adjust token ID display.getNFTto fetch token ID by index iftokenByIndexis true.