Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 26, 2025


PR-Codex overview

This PR introduces enhancements to the login-form.tsx and config.ts files, including a new configuration for the "Mode Earn App" and a comment indicating future support for multiple chainIds.

Detailed summary

  • Added a comment in login-form.tsx about handling multiple chainIds.
  • Updated getLoginConfig function in config.ts:
    • Introduced a new configuration for the "Mode Earn App" with id, name, logo, logoLink, and chainId.
    • Set sessionKeySignerAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 4:17am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 26, 2025 4:17am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 26, 2025 4:17am
thirdweb-www ⬜️ Skipped (Inspect) Feb 26, 2025 4:17am
wallet-ui ⬜️ Skipped (Inspect) Feb 26, 2025 4:17am

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 26, 2025 04:15 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 81b13cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 04:15 Inactive
@joaquim-verges joaquim-verges changed the title update config [Login] update config Feb 26, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 1.6 s (-31.95% 🔽) 2.5 s
thirdweb (cjs) 124.25 KB (0%) 2.5 s (0%) 4.9 s (+31.19% 🔺) 7.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 339 ms (+63.9% 🔺) 451 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 205 ms (+636.45% 🔺) 215 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 414 ms (-21.32% 🔽) 801 ms

@joaquim-verges joaquim-verges merged commit 84d1623 into main Feb 26, 2025
31 of 36 checks passed
@joaquim-verges joaquim-verges deleted the 02-26-update_config branch February 26, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants