Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 26, 2025


PR-Codex overview

This PR focuses on updating the logo and logoLink properties in the config.ts file, as well as enhancing the session key management in the login-form.tsx file by introducing permission checks and refactoring related logic for better clarity and maintainability.

Detailed summary

  • Updated logo and logoLink in config.ts.
  • Added shouldUpdateSessionKey import in login-form.tsx.
  • Introduced newPermissions object for permission management.
  • Refactored session key update logic to check if an update is needed.
  • Simplified the return logic for session key status.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 8:20am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 27, 2025 8:20am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 27, 2025 8:20am
thirdweb-www ⬜️ Skipped (Inspect) Feb 27, 2025 8:20am
wallet-ui ⬜️ Skipped (Inspect) Feb 27, 2025 8:20am

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: ec04a65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 26, 2025 09:12 Inactive
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 802 ms (+96.47% 🔺) 1.8 s
thirdweb (cjs) 124.42 KB (0%) 2.5 s (0%) 1.2 s (+29.56% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 119 ms (+86.15% 🔺) 231 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 76 ms (+153.9% 🔺) 86 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 111 ms (+0.98% 🔺) 498 ms

@joaquim-verges joaquim-verges force-pushed the 02-26-use_shouldupdatesessionkey_in_login_flow branch from 5a4f80d to 0dab27e Compare February 26, 2025 11:09
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 11:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 11:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 11:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 26, 2025 11:09 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review February 26, 2025 11:09
@joaquim-verges joaquim-verges requested review from a team as code owners February 26, 2025 11:09
@joaquim-verges joaquim-verges force-pushed the 02-26-use_shouldupdatesessionkey_in_login_flow branch from 0dab27e to 29f9183 Compare February 26, 2025 11:23
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 26, 2025 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 11:23 Inactive
@joaquim-verges joaquim-verges force-pushed the 02-26-use_shouldupdatesessionkey_in_login_flow branch from 29f9183 to f336ee7 Compare February 26, 2025 23:37
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 26, 2025
@joaquim-verges joaquim-verges force-pushed the 02-26-use_shouldupdatesessionkey_in_login_flow branch from f336ee7 to ec04a65 Compare February 27, 2025 08:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 27, 2025 08:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 27, 2025 08:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 27, 2025 08:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 27, 2025 08:15 Inactive
@joaquim-verges joaquim-verges merged commit 21938f9 into main Feb 27, 2025
29 of 31 checks passed
@joaquim-verges joaquim-verges deleted the 02-26-use_shouldupdatesessionkey_in_login_flow branch February 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants