Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 27, 2025

PR-Codex overview

This PR focuses on updating redirect rules in the redirects.mjs and redirects.js files within the portal and dashboard applications, respectively. It removes a specific redirect for /storage and modifies the structure of the remaining redirects.

Detailed summary

  • Removed the redirect for "/storage" to the portal.
  • Updated the path for "/storage" to point to "/infrastructure/storage/overview".
  • Retained existing redirects for "/storage/how-storage-works" and "/storage/upload-to-ipfs".
  • Maintained the redirect for "/rpc-edge" in redirects.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested review from a team as code owners February 27, 2025 15:58
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 27, 2025 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 27, 2025 15:58 Inactive
@vercel
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:14pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:14pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:14pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:14pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:14pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 27, 2025 15:58 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 6cad6d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 27, 2025
Copy link
Contributor Author

arcoraven commented Feb 27, 2025

Merge activity

  • Feb 27, 10:58 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 27, 11:27 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Feb 27, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 499 ms (+51.48% 🔺) 1.5 s
thirdweb (cjs) 124.42 KB (0%) 2.5 s (0%) 1.1 s (+20.43% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 117 ms (+87.53% 🔺) 229 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 17 ms (+26% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 214 ms (+114.22% 🔺) 601 ms

@jnsdls jnsdls merged commit 566b5b9 into main Feb 27, 2025
29 of 30 checks passed
@jnsdls jnsdls deleted the ph/remove-storage-redirect branch February 27, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants