Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 19, 2025


PR-Codex overview

This PR introduces a fixed gas limit for transactions on the Saga Mainnet, specifically when the chain ID is 5464. This ensures that all transactions on this network adhere to a predetermined gas limit.

Detailed summary

  • Added a check for the Saga Mainnet with chain ID 5464.
  • If the condition is met, it returns a fixed gas limit of 20000000n for transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:25pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:25pm
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:25pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:25pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:25pm

@joaquim-verges joaquim-verges marked this pull request as ready for review March 19, 2025 20:17
@joaquim-verges joaquim-verges requested review from a team as code owners March 19, 2025 20:17
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 19, 2025
Copy link
Member Author

joaquim-verges commented Mar 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges merged commit 6672549 into main Mar 19, 2025
26 of 30 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_feat_Add_fixed_gas_limit_for_Saga_Mainnet branch March 19, 2025 20:17
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.9 KB (0%) 938 ms (0%) 214 ms (+174.52% 🔺) 1.2 s
thirdweb (cjs) 127.28 KB (0%) 2.6 s (0%) 283 ms (+23.7% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 98 ms (+1352.55% 🔺) 210 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+1825.32% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 83 ms (+370.25% 🔺) 470 ms

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.77%. Comparing base (639b542) to head (a5f8c05).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/thirdweb/src/transaction/actions/estimate-gas.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6500      +/-   ##
==========================================
- Coverage   54.78%   54.77%   -0.01%     
==========================================
  Files         875      875              
  Lines       54903    54906       +3     
  Branches     3745     3743       -2     
==========================================
  Hits        30077    30077              
- Misses      24731    24734       +3     
  Partials       95       95              
Flag Coverage Δ
packages 54.77% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...s/thirdweb/src/transaction/actions/estimate-gas.ts 74.41% <0.00%> (-2.69%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants