-
Notifications
You must be signed in to change notification settings - Fork 620
[Playground] Refactor Universal Bridge sidebar links and update order #6543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] Refactor Universal Bridge sidebar links and update order #6543
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
==========================================
+ Coverage 54.92% 55.02% +0.10%
==========================================
Files 881 881
Lines 55179 55304 +125
Branches 3768 3788 +20
==========================================
+ Hits 30309 30433 +124
- Misses 24775 24776 +1
Partials 95 95
🚀 New features to boost your workflow:
|
size-limit report 📦
|
ddddb47 to
6f828a1
Compare
6f828a1 to
677af8f
Compare
677af8f to
d4402be
Compare
d4402be to
c33f39d
Compare
| export default async function Page(props: { | ||
| searchParams: Promise<{ | ||
| route: string; | ||
| }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The searchParams prop is typed as a Promise<{ route: string }>, but Next.js provides this parameter directly as an object. This causes an unnecessary await on line 19.
Consider updating the type signature to:
searchParams: {
route: string;
}And then remove the await when accessing params.route. This will align with Next.js's API and simplify the code.
| export default async function Page(props: { | |
| searchParams: Promise<{ | |
| route: string; | |
| }>; | |
| export default async function Page(props: { | |
| searchParams: { | |
| route: string; | |
| }; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
c33f39d to
7dd4e0e
Compare
7dd4e0e to
46476a0
Compare

PR-Codex overview
This PR primarily focuses on enhancing the
Universal Bridgefeature in the application by adding new UI components, improving API integration, and organizing sidebar links for better navigation.Detailed summary
clientIdto the client configuration inlib/client.ts.PayEmbed.tsxandlayout.tsx.Universal Bridgelinks.utils.ts.Universal Bridge API.