Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 24, 2025


PR-Codex overview

This PR primarily focuses on enhancing the Universal Bridge feature in the application by adding new UI components, improving API integration, and organizing sidebar links for better navigation.

Detailed summary

  • Added clientId to the client configuration in lib/client.ts.
  • Introduced new UI components in PayEmbed.tsx and layout.tsx.
  • Enhanced sidebar navigation with Universal Bridge links.
  • Implemented API fetching logic in utils.ts.
  • Created a new reference page for the Universal Bridge API.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:20am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:20am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:20am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:20am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:20am

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 22:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 22:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 24, 2025 22:14 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 46476a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 22:14 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review March 24, 2025 22:14
@joaquim-verges joaquim-verges requested review from a team as code owners March 24, 2025 22:14
@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages labels Mar 24, 2025
Copy link
Member Author

joaquim-verges commented Mar 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 22:15 Inactive
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (ab7bf1a) to head (46476a0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6543      +/-   ##
==========================================
+ Coverage   54.92%   55.02%   +0.10%     
==========================================
  Files         881      881              
  Lines       55179    55304     +125     
  Branches     3768     3788      +20     
==========================================
+ Hits        30309    30433     +124     
- Misses      24775    24776       +1     
  Partials       95       95              
Flag Coverage Δ
packages 55.02% <ø> (+0.10%) ⬆️
Files with missing lines Coverage Δ
.../thirdweb/src/extensions/thirdweb/write/publish.ts 92.22% <ø> (ø)
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 42.00% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 148 ms (+131.89% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 232 ms (+50.88% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 75 ms (+1243.19% 🔺) 187 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (+3054.69% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 117 ms (+927.76% 🔺) 504 ms

@joaquim-verges joaquim-verges force-pushed the _Playground_Refactor_Universal_Bridge_sidebar_links_and_update_order branch from 6f828a1 to 677af8f Compare March 25, 2025 01:48
Comment on lines +14 to +17
export default async function Page(props: {
searchParams: Promise<{
route: string;
}>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The searchParams prop is typed as a Promise<{ route: string }>, but Next.js provides this parameter directly as an object. This causes an unnecessary await on line 19.

Consider updating the type signature to:

searchParams: {
  route: string;
}

And then remove the await when accessing params.route. This will align with Next.js's API and simplify the code.

Suggested change
export default async function Page(props: {
searchParams: Promise<{
route: string;
}>;
export default async function Page(props: {
searchParams: {
route: string;
};

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@joaquim-verges joaquim-verges force-pushed the _Playground_Refactor_Universal_Bridge_sidebar_links_and_update_order branch from 7dd4e0e to 46476a0 Compare March 25, 2025 02:13
@joaquim-verges joaquim-verges merged commit dd65506 into main Mar 25, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _Playground_Refactor_Universal_Bridge_sidebar_links_and_update_order branch March 25, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants