Skip to content

Add glossary slug route to framer rewrites #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Add glossary slug route to framer rewrites #6594

merged 1 commit into from
Mar 31, 2025
+1 −0

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 31, 2025 •
edited by pr-codex bot
Loading

TL;DR

Added a rewrite rule for glossary detail pages in the dashboard app.

What changed?

Added a new path /learn/glossary/:glossary_slug to the framer-rewrites.js file to support individual glossary term pages.

How to test?

  1. Navigate to a glossary term detail page (e.g., /learn/glossary/some-term)
  2. Verify that the page loads correctly and the routing works as expected

Why make this change?

To enable proper routing for individual glossary term pages, allowing users to access specific glossary entries directly through their unique URLs. This complements the existing glossary index page that was already configured.

PR-Codex overview

This PR focuses on updating the framer-rewrites.js file by adding a new route for glossary items in the application.

Detailed summary

  • Added a new route "/learn/glossary/:glossary_slug" to the existing routes in the framer-rewrites.js file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 6:07pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 31, 2025 6:07pm
login ⬜️ Skipped (Inspect) Mar 31, 2025 6:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 31, 2025 6:07pm
wallet-ui ⬜️ Skipped (Inspect) Mar 31, 2025 6:07pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 17:53 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 05a041f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 17:53 Inactive
@jnsdls jnsdls marked this pull request as ready for review March 31, 2025 17:53
@jnsdls jnsdls requested review from a team as code owners March 31, 2025 17:53
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 31, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Mar 31, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (3d140ee) to head (05a041f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6594   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files         885      885           
  Lines       55517    55517           
  Branches     3793     3793           
=======================================
  Hits        30513    30513           
  Misses      24911    24911           
  Partials       93       93
Flag Coverage Δ
packages 54.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 208 ms (+214.2% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 304 ms (+99.46% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 141 ms (+2780.47% 🔺) 253 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 40 ms (+1809.27% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 112 ms (+671.29% 🔺) 499 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 31, 2025 •
edited
Loading

Merge activity

@jnsdls
Add glossary slug route to framer rewrites (#6594)
05a041f 
### TL;DR

Added a rewrite rule for glossary detail pages in the dashboard app.

### What changed?

Added a new path `/learn/glossary/:glossary_slug` to the framer-rewrites.js file to support individual glossary term pages.

### How to test?

1. Navigate to a glossary term detail page (e.g., `/learn/glossary/some-term`)
2. Verify that the page loads correctly and the routing works as expected

### Why make this change?

To enable proper routing for individual glossary term pages, allowing users to access specific glossary entries directly through their unique URLs. This complements the existing glossary index page that was already configured.
@graphite-app graphite-app bot force-pushed the Add_glossary_slug_route_to_framer_rewrites branch from e3d2b4d to 05a041f Compare March 31, 2025 18:00
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 18:00 Inactive
@graphite-app graphite-app bot merged commit 05a041f into main Mar 31, 2025
32 checks passed
@graphite-app graphite-app bot deleted the Add_glossary_slug_route_to_framer_rewrites branch March 31, 2025 18:07
@vercel vercel bot temporarily deployed to Production – wallet-ui March 31, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 31, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Production – login March 31, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 31, 2025 18:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank