Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 1, 2025


PR-Codex overview

This PR focuses on enhancing the user experience for managing contracts by replacing the GetStartedWithContractsDeploy component with a new DeployViaCLIOrImportCard, improving messaging, and adding a link to discover contracts.

Detailed summary

  • Removed GetStartedWithContractsDeploy component.
  • Added DeployViaCLIOrImportCard component for contract deployment options.
  • Updated the "No Contracts" message to include a button linking to contract discovery.
  • Increased height of the "No Contracts" placeholder.
  • Added ExternalLinkIcon to the new button.
  • Modified styles for better spacing and layout.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 1, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 73ae581

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:19am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 2, 2025 9:19am
login ⬜️ Skipped (Inspect) Apr 2, 2025 9:19am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 2, 2025 9:19am
wallet-ui ⬜️ Skipped (Inspect) Apr 2, 2025 9:19am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 1, 2025
@MananTank MananTank marked this pull request as ready for review April 1, 2025 18:23
Copy link
Member Author

MananTank commented Apr 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank requested review from a team as code owners April 1, 2025 18:23
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (2ef8f2a) to head (73ae581).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6611      +/-   ##
==========================================
- Coverage   54.96%   54.96%   -0.01%     
==========================================
  Files         887      887              
  Lines       55650    55652       +2     
  Branches     3798     3799       +1     
==========================================
+ Hits        30590    30591       +1     
- Misses      24965    24966       +1     
  Partials       95       95              
Flag Coverage Δ
packages 54.96% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 133 ms (+140.38% 🔺) 1.1 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 205 ms (+21.71% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 55 ms (+1080.38% 🔺) 167 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 30 ms (+1497.5% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 94 ms (+563.36% 🔺) 480 ms

@graphite-app graphite-app bot changed the base branch from tool-3762 to graphite-base/6611 April 2, 2025 07:10
@graphite-app graphite-app bot force-pushed the graphite-base/6611 branch from 203d46e to 7eaf86a Compare April 2, 2025 07:18
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 07:19 Inactive
@graphite-app graphite-app bot changed the base branch from graphite-base/6611 to main April 2, 2025 07:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 07:19 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the user interface and functionality of the contracts management section. It introduces new components and modifies existing ones to improve user experience, particularly around contract deployment and management.

### Detailed summary
- Removed the `GetStartedWithContractsDeploy` component.
- Added `DeployViaCLIOrImportCard` component for contract deployment options.
- Updated the `DeployedContractsPage` to include the new `DeployViaCLIOrImportCard`.
- Modified the `ContractTableUI` to display a message and button when no contracts are present.
- Increased the height of the no contracts message section.
- Added a link to discover contracts with an external icon.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 09:12 Inactive
@graphite-app graphite-app bot merged commit 73ae581 into main Apr 2, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3763 branch April 2, 2025 09:20
@vercel vercel bot temporarily deployed to Production – docs-v2 April 2, 2025 09:20 Inactive
@vercel vercel bot temporarily deployed to Production – login April 2, 2025 09:20 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 2, 2025 09:20 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 2, 2025 09:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants