Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 4, 2025

PR-Codex overview

This PR updates the middleware configuration in apps/dashboard/src/middleware.ts to refine the URL pattern exclusions for static assets, specifically adding more favicon images and sitemap files to the ignore list.

Detailed summary

  • Updated the regex pattern in the middleware to exclude:
    • sitemap.xml
    • sitemap-0.xml
    • favicon-16x16.png
    • favicon-32x32.png
    • apple-touch-icon.png
    • android-chrome-192x192.png
    • android-chrome-512x512.png

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 8f7bcae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 2:27pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 4, 2025 2:27pm
login ⬜️ Skipped (Inspect) Apr 4, 2025 2:27pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 4, 2025 2:27pm
wallet-ui ⬜️ Skipped (Inspect) Apr 4, 2025 2:27pm

@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 4, 2025 14:08 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 4, 2025 14:09
@MananTank MananTank requested review from a team as code owners April 4, 2025 14:09
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Apr 4, 2025 — with Graphite App
Copy link
Member Author

MananTank commented Apr 4, 2025

Merge activity

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (ad7f78c) to head (8f7bcae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6647   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         889      889           
  Lines       55768    55768           
  Branches     3816     3816           
=======================================
  Hits        30665    30665           
  Misses      25008    25008           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 259 ms (+38.65% 🔺) 1.3 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 647 ms (+13.43% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 85 ms (+184.77% 🔺) 197 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 30 ms (+493.52% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 128 ms (+175.93% 🔺) 515 ms

@graphite-app graphite-app bot force-pushed the 04-04-dashboard_fix_sitemap.xml_and_other_files_on_public_folder_not_loading branch from 4769416 to 8f7bcae Compare April 4, 2025 14:20
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 4, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 14:20 Inactive
@graphite-app graphite-app bot merged commit 8f7bcae into main Apr 4, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-04-dashboard_fix_sitemap.xml_and_other_files_on_public_folder_not_loading branch April 4, 2025 14:28
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Apr 4, 2025
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 4, 2025 14:28 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 4, 2025 14:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants