-
Notifications
You must be signed in to change notification settings - Fork 620
[TOOL-3876] Dashboard: Merge Framer sitemap.xml to dashboard sitemap.xml #6648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
jnsdls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 889 889
Lines 55768 55768
Branches 3816 3816
=======================================
Hits 30665 30665
Misses 25008 25008
Partials 95 95
🚀 New features to boost your workflow:
|
Merge activity
|
…xml (#6648) <!-- start pr-codex --> ## PR-Codex overview This PR primarily introduces the `fast-xml-parser` package to the project and updates the `fetchChainsFromApi` function to fetch and parse XML data. It also modifies the sitemap generation logic to utilize the newly added functionality. ### Detailed summary - Added `fast-xml-parser` to `package.json` and `pnpm-lock.yaml`. - Updated `next-sitemap.config.js` to require `fast-xml-parser`. - Introduced a new function `getFramerXML` to fetch and parse XML data. - Modified `additionalPaths` to use data from `getFramerXML`. - Adjusted the return structure of URLs in `additionalPaths`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
3130d4a to
6636277
Compare

PR-Codex overview
This PR introduces the
fast-xml-parserlibrary to the project, enhancing the ability to fetch and parse XML data. It modifies thefetchChainsFromApifunction and adds a newgetFramerXMLfunction to handle XML parsing for sitemap URLs.Detailed summary
fast-xml-parserdependency inpackage.jsonandpnpm-lock.yaml.next-sitemap.config.js:getFramerXMLfunction to fetch and parse XML from a sitemap.additionalPathsto usePromise.allfor fetching framer URLs and chains.fetchChainsFromApifunction documentation.