Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 4, 2025

PR-Codex overview

This PR introduces the fast-xml-parser library to the project, enhancing the ability to fetch and parse XML data. It modifies the fetchChainsFromApi function and adds a new getFramerXML function to handle XML parsing for sitemap URLs.

Detailed summary

  • Added fast-xml-parser dependency in package.json and pnpm-lock.yaml.
  • Updated next-sitemap.config.js:
    • Introduced getFramerXML function to fetch and parse XML from a sitemap.
    • Modified additionalPaths to use Promise.all for fetching framer URLs and chains.
  • Adjusted fetchChainsFromApi function documentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 4, 2025

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:05pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:05pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:05pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:05pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:05pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 6636277

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security
Copy link

socket-security bot commented Apr 4, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/fast-xml-parser@5.2.0 None +1 556 kB amitgupta

View full report↗︎

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 190 ms (+131.09% 🔺) 1.2 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 317 ms (+34.29% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 110 ms (+1444.15% 🔺) 222 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 68 ms (+2611.7% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 149 ms (+766.09% 🔺) 537 ms

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (8f7bcae) to head (6636277).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6648   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         889      889           
  Lines       55768    55768           
  Branches     3816     3816           
=======================================
  Hits        30665    30665           
  Misses      25008    25008           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

Merge activity

…xml (#6648)

<!-- start pr-codex -->

## PR-Codex overview
This PR primarily introduces the `fast-xml-parser` package to the project and updates the `fetchChainsFromApi` function to fetch and parse XML data. It also modifies the sitemap generation logic to utilize the newly added functionality.

### Detailed summary
- Added `fast-xml-parser` to `package.json` and `pnpm-lock.yaml`.
- Updated `next-sitemap.config.js` to require `fast-xml-parser`.
- Introduced a new function `getFramerXML` to fetch and parse XML data.
- Modified `additionalPaths` to use data from `getFramerXML`.
- Adjusted the return structure of URLs in `additionalPaths`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants