Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 4, 2025

PR-Codex overview

This PR focuses on enhancing validation for an array in the blueprint-playground.client.tsx file by ensuring that if the array is required, it must have at least one item.

Detailed summary

  • Modified the return statement for required arrays to include a minimum length check using z.array(itemSchema).min(1, { message: "Required" }).
  • The optional case remains unchanged, returning z.array(itemSchema).optional().

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 9c737a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 8:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 4, 2025 8:00pm
login ⬜️ Skipped (Inspect) Apr 4, 2025 8:00pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 4, 2025 8:00pm
wallet-ui ⬜️ Skipped (Inspect) Apr 4, 2025 8:00pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 4, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 19:53 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Apr 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.97%. Comparing base (646a5a3) to head (9c737a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6654   +/-   ##
=======================================
  Coverage   54.97%   54.97%           
=======================================
  Files         889      889           
  Lines       55768    55768           
  Branches     3815     3815           
=======================================
  Hits        30661    30661           
  Misses      25012    25012           
  Partials       95       95           
Flag Coverage Δ
packages 54.97% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 150 ms (+165.83% 🔺) 1.2 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 221 ms (+27.01% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 72 ms (+1251.26% 🔺) 185 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 28 ms (+890.78% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 105 ms (+742.08% 🔺) 492 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-05-insight_playground_show_error_when_no_chains_selected branch from 5d3f7e1 to 9c737a1 Compare April 4, 2025 19:59
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 4, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 19:59 Inactive
@graphite-app graphite-app bot merged commit 9c737a1 into main Apr 4, 2025
31 checks passed
@graphite-app graphite-app bot deleted the 04-05-insight_playground_show_error_when_no_chains_selected branch April 4, 2025 20:03
@vercel vercel bot temporarily deployed to Production – docs-v2 April 4, 2025 20:03 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 4, 2025 20:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 4, 2025 20:03 Inactive
@vercel vercel bot temporarily deployed to Production – login April 4, 2025 20:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants