Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 15, 2025


PR-Codex overview

This PR refactors the logic for setting chainIds in updatedContextFilters to ensure that the last used chains from storage are only retrieved if chainIds is empty. It also maintains error handling for local storage access.

Detailed summary

  • Moved the check for empty chainIds to before retrieving last used chains.
  • Retained the logic to fetch lastUsedChainIds if chainIds is empty.
  • Preserved error handling for local storage access.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 15, 2025 22:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 15, 2025 22:09 Inactive
@vercel
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 10:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 15, 2025 10:23pm
login ⬜️ Skipped (Inspect) Apr 15, 2025 10:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 15, 2025 10:23pm
wallet-ui ⬜️ Skipped (Inspect) Apr 15, 2025 10:23pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 15, 2025 22:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 15, 2025 22:09 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

⚠️ No Changeset found

Latest commit: 64bd603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 15, 2025
@MananTank MananTank marked this pull request as ready for review April 15, 2025 22:09
@MananTank MananTank requested review from a team as code owners April 15, 2025 22:09
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (60a5b7c) to head (64bd603).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6738   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         895      895           
  Lines       56384    56384           
  Branches     3850     3850           
=======================================
  Hits        30899    30899           
  Misses      25390    25390           
  Partials       95       95           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (0%) 1.1 s (0%) 257 ms (+135.84% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (0%) 2.8 s (0%) 377 ms (+45.56% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.64 KB (0%) 113 ms (0%) 78 ms (+903% 🔺) 190 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 72 ms (+3190.28% 🔺) 82 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (0%) 388 ms (0%) 112 ms (+498.66% 🔺) 500 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 15, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refines the logic for updating `updatedContextFilters.chainIds` by ensuring that it only attempts to retrieve last used chains from storage when `chainIds` is empty. It also maintains error handling for local storage access.

### Detailed summary
- Moved the check for `updatedContextFilters.chainIds` length to before retrieving last used chains.
- Retained the logic to fetch last used chain IDs from storage if `chainIds` is empty.
- Preserved error handling for local storage access.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-16-nebula_do_not_override_chains_set_from_search_params branch from 9cd04d1 to 64bd603 Compare April 15, 2025 22:16
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 15, 2025 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 15, 2025 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 15, 2025 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 15, 2025 22:16 Inactive
@graphite-app graphite-app bot merged commit 64bd603 into main Apr 15, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 04-16-nebula_do_not_override_chains_set_from_search_params branch April 15, 2025 22:23
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 15, 2025 22:23 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 15, 2025 22:23 Inactive
@vercel vercel bot temporarily deployed to Production – login April 15, 2025 22:23 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 15, 2025 22:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants