Skip to content

[SDK] Handle fixed size arrays in solidity inputs #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

[SDK] Handle fixed size arrays in solidity inputs #6870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-carpets-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Handle fixed size arrays in solidity inputs
5 changes: 4 additions & 1 deletion apps/dashboard/src/contract-ui/components/solidity-inputs/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ export const validateAddress = (value: string) => {

// all
export const validateSolidityInput = (value: string, solidityType: string) => {
if (solidityType.startsWith("int") || solidityType.startsWith("uint")) {
if (
(solidityType.startsWith("int") || solidityType.startsWith("uint")) &&
!solidityType.endsWith("]")
) {
return validateInt(value, solidityType);
}
// TODO: bytes array not working right now
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/src/contract-ui/components/solidity-inputs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const SolidityInput = forwardRef<
);
}

if (solidityType?.endsWith("[]")) {
if (solidityType?.endsWith("]")) {
return (
<SolidityRawInput
formContext={form}
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/utils/contract/parse-abi-params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function parseAbiParams(
}
return constructorParamTypes.map((type, index) => {
const value = constructorParamValues[index];
if (type === "tuple" || type.endsWith("[]")) {
if (type === "tuple" || type.endsWith("]")) {
if (typeof value === "string") {
return JSON.parse(value);
}
Expand Down
Loading