[TOOL-4309] Dashbaord: Fix stripe new tab not opening on mobile #6879
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6879 +/- ##
=======================================
Coverage 55.21% 55.21%
=======================================
Files 896 896
Lines 57057 57057
Branches 3957 3957
=======================================
Hits 31502 31502
Misses 25459 25459
Partials 96 96
🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the billing-related functionalities and improving the loading and error handling components in the application. It removes unnecessary async functions for URL retrieval and replaces them with direct URL constructions.
### Detailed summary
- Removed async functions for `getBillingPortalUrl` and `getBillingCheckoutUrl`.
- Introduced `buildCheckoutUrl`, `buildCancelPlanUrl`, and `buildBillingPortalUrl` functions.
- Updated components to use the new URL-building functions.
- Enhanced loading and error handling components: `Loading`, `StripeRedirectErrorPage`.
- Simplified storybook components by removing unnecessary props.
- Updated billing-related components to reflect changes in URL handling.
- Cleaned up imports and removed unused variables related to billing URLs.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
tool-4309
branch
from
62a088e to
bd9594d
Compare
PR-Codex overview
This PR focuses on refactoring billing-related functions and components in the application, improving the structure and usability of billing URLs, and enhancing the user interface for billing alerts and loading states.
Detailed summary
getBillingCheckoutUrlandgetBillingPortalUrlprops from various components.utils/build-url.tsfor building billing URLs.StripeRedirectErrorPagefor error handling in the checkout process.CancelPlanPageandManageBillingPageto use new billing URL functions.PricingCardandBillingPricingcomponents to use new URL building functions.Loadingcomponent.