Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 30, 2025


PR-Codex overview

This PR focuses on restructuring the project to accommodate a new dedicated engine layout, enhancing the project_slug handling across various components, and improving the overall organization of the engine's codebase for better maintainability.

Detailed summary

  • Introduced project_slug in various components and functions.
  • Updated routes to reflect the new dedicated engine structure.
  • Refactored components to use project_slug for consistency.
  • Modified loading and error handling pages.
  • Enhanced sidebar navigation and links to accommodate new structure.
  • Adjusted API calls to include project_slug.
  • Updated UI elements to reflect changes in the project structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges requested review from a team as code owners April 30, 2025 12:01
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 56251e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 0:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 30, 2025 0:07am
login ⬜️ Skipped (Inspect) Apr 30, 2025 0:07am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 30, 2025 0:07am
wallet-ui ⬜️ Skipped (Inspect) Apr 30, 2025 0:07am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 30, 2025
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (7e00c49) to head (56251e2).
Report is 1 commits behind head on tool-3337.

Additional details and impacted files
@@            Coverage Diff             @@
##           tool-3337    #6892   +/-   ##
==========================================
  Coverage      55.21%   55.21%           
==========================================
  Files            896      896           
  Lines          57057    57057           
  Branches        3955     3955           
==========================================
  Hits           31506    31506           
  Misses         25454    25454           
  Partials          97       97           
Flag Coverage Δ
packages 55.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (0%) 1.1 s (0%) 219 ms (+191.34% 🔺) 1.3 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 333 ms (+94.69% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 77 ms (+1178.49% 🔺) 190 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 28 ms (+1894.67% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 124 ms (+987.81% 🔺) 512 ms

@joaquim-verges joaquim-verges merged commit 462e44f into tool-3337 Apr 30, 2025
22 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/engine-legacy branch April 30, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants