Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Apr 30, 2025

[Portal] Fix: Remove webhook verification details from documentation

Notes for the reviewer

This PR simplifies the webhooks documentation by removing detailed information about the webhook verification process, including OTP verification steps, URL updating requirements, and the API endpoints for verification and OTP resending.

How to test

Review the updated documentation page to ensure it still provides clear information about the core webhook management functionality without the removed verification details.


PR-Codex overview

This PR focuses on updating the documentation for managing webhooks, specifically clarifying the verification process, updating webhook URLs, and the OTP (One-Time Password) functionality.

Detailed summary

  • Removed details about verifying the created webhook, including OTP verification and timing.
  • Clarified that updating the webhook URL requires re-verification with a new OTP.
  • Added a section for verifying webhooks and resending OTPs, with specific requirements and expiry information.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: cd12ef7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Apr 30, 2025
Copy link
Contributor Author

iuwqyir commented Apr 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir marked this pull request as ready for review April 30, 2025 18:58
@iuwqyir iuwqyir requested review from a team as code owners April 30, 2025 18:58
@vercel
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 8:07pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Apr 30, 2025 8:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 30, 2025 8:07pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 30, 2025 8:07pm
wallet-ui ⬜️ Skipped (Inspect) Apr 30, 2025 8:07pm

@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 30, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 18:58 Inactive
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (2832828) to head (cd12ef7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6896   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files         896      896           
  Lines       57057    57057           
  Branches     3955     3955           
=======================================
  Hits        31506    31506           
  Misses      25454    25454           
  Partials       97       97           
Flag Coverage Δ
packages 55.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (0%) 1.1 s (0%) 160 ms (+167.46% 🔺) 1.2 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 288 ms (+40.85% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 62 ms (+938.73% 🔺) 176 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 25 ms (+752.93% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 91 ms (+682.26% 🔺) 478 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 30, 2025

Merge activity

## [Portal] Fix: Remove webhook verification details from documentation

## Notes for the reviewer

This PR simplifies the webhooks documentation by removing detailed information about the webhook verification process, including OTP verification steps, URL updating requirements, and the API endpoints for verification and OTP resending.

## How to test

Review the updated documentation page to ensure it still provides clear information about the core webhook management functionality without the removed verification details.
@graphite-app graphite-app bot force-pushed the 04-30-remove_otp_from_insight_docs branch from 3397053 to cd12ef7 Compare April 30, 2025 20:05
@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 20:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 20:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 20:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 30, 2025 20:05 Inactive
@graphite-app graphite-app bot merged commit cd12ef7 into main Apr 30, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 04-30-remove_otp_from_insight_docs branch April 30, 2025 20:09
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 30, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Production – login April 30, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 30, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 30, 2025 20:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants