Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 30, 2025


PR-Codex overview

This PR focuses on modifying the NebulaConnectButton component by adding a new prop to control auto-connection behavior.

Detailed summary

  • Added a comment indicating that an AutoConnect is already present in the root layout with AA configuration.
  • Introduced a new prop autoConnect set to false in the NebulaConnectButton component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 11:04pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 30, 2025 11:04pm
login ⬜️ Skipped (Inspect) Apr 30, 2025 11:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 30, 2025 11:04pm
wallet-ui ⬜️ Skipped (Inspect) Apr 30, 2025 11:04pm

@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 22:43 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 818189e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 30, 2025 22:43 Inactive
@MananTank MananTank marked this pull request as ready for review April 30, 2025 22:43
@MananTank MananTank requested review from a team as code owners April 30, 2025 22:43
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 30, 2025
Copy link
Member Author

MananTank commented Apr 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 05-01-nebula_fix_nebula_auto_connect branch from c6ded1c to a8d2816 Compare April 30, 2025 22:44
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 30, 2025 22:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 22:44 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 22:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 22:44 Inactive
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Apr 30, 2025 — with Graphite App
@MananTank MananTank force-pushed the 05-01-nebula_fix_nebula_auto_connect branch from a8d2816 to 32862ef Compare April 30, 2025 22:45
@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 30, 2025 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 22:45 Inactive
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (7306818) to head (818189e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6899   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files         896      896           
  Lines       57057    57057           
  Branches     3955     3955           
=======================================
  Hits        31506    31506           
  Misses      25454    25454           
  Partials       97       97           
Flag Coverage Δ
packages 55.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (-0.05% 🔽) 1.1 s (-0.05% 🔽) 177 ms (+139.67% 🔺) 1.3 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 307 ms (+59.7% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 53 ms (+777.51% 🔺) 166 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 28 ms (+1269.57% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 100 ms (+772.93% 🔺) 488 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 30, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR modifies the `NebulaConnectButton` component by adding an `autoConnect` prop set to `false`, clarifying that an `AutoConnect` feature is already implemented at the root layout with an AA configuration.

### Detailed summary
- Added `autoConnect={false}` prop to the `NebulaConnectButton` component.
- Included a comment indicating that an `AutoConnect` is already present in the root layout with AA configuration.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 05-01-nebula_fix_nebula_auto_connect branch from 32862ef to 818189e Compare April 30, 2025 22:56
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 30, 2025 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 30, 2025 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 30, 2025 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 30, 2025 22:57 Inactive
@graphite-app graphite-app bot merged commit 818189e into main Apr 30, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 05-01-nebula_fix_nebula_auto_connect branch April 30, 2025 23:04
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Apr 30, 2025
@vercel vercel bot temporarily deployed to Production – wallet-ui April 30, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 30, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 30, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Production – login April 30, 2025 23:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants