Skip to content

Nebula: Update Reasoning UI: show only latest presence in pending state #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Nebula: Update Reasoning UI: show only latest presence in pending state #6913

merged 1 commit into from
May 1, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 1, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR enhances the Reasoning component by modifying how text is displayed based on the isPending prop. It introduces a new variable to determine if all texts should be shown and updates the rendering logic accordingly.

Detailed summary

  • Added showAll variable to determine text visibility.
  • Introduced lastText to capture the last element in props.texts.
  • Updated the rendering logic to conditionally display either all texts or just the last text based on showAll.
  • Changed the class name of the <span> from default to text-foreground.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 293b246

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 6:17pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 1, 2025 6:17pm
login ⬜️ Skipped (Inspect) May 1, 2025 6:17pm
thirdweb_playground ⬜️ Skipped (Inspect) May 1, 2025 6:17pm
wallet-ui ⬜️ Skipped (Inspect) May 1, 2025 6:17pm

@vercel vercel bot temporarily deployed to Preview – login May 1, 2025 17:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 1, 2025 17:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 1, 2025 17:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 1, 2025 17:38 Inactive
@MananTank MananTank marked this pull request as ready for review May 1, 2025 17:38
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 1, 2025
@MananTank MananTank requested a review from a team as a code owner May 1, 2025 17:38
@MananTank MananTank requested a review from a team as a code owner May 1, 2025 17:38
@MananTank MananTank mentioned this pull request May 1, 2025
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented May 1, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented May 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.11%. Comparing base (a317772) to head (293b246).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6913   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         896      896           
  Lines       57192    57192           
  Branches     3955     3955           
=======================================
  Hits        31519    31519           
  Misses      25576    25576           
  Partials       97       97
Flag Coverage Δ
packages 55.11% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (0%) 1.1 s (0%) 292 ms (+214.38% 🔺) 1.4 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 548 ms (+104.87% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 116 ms (+773.36% 🔺) 230 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 31 ms (+940.48% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 117 ms (+574.07% 🔺) 505 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 1, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from neb-225 to graphite-base/6913 May 1, 2025 18:00
@graphite-app graphite-app bot changed the base branch from graphite-base/6913 to main May 1, 2025 18:10
@MananTank
Nebula: Update Reasoning UI: show only latest presence in pending sta…
293b246 
…te (#6913)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `Reasoning` component in the `Reasoning.tsx` file by improving the handling of text display based on the `isPending` prop, adding conditional rendering for showing all texts or just the last one.

### Detailed summary
- Added `showAll` variable to determine if all texts should be displayed.
- Introduced `lastText` to hold the last item from `props.texts`.
- Updated the rendering logic to conditionally show all texts or just the last one based on `showAll`.
- Changed `<span>` to `<span className="text-foreground">` for styling consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 05-01-nebula_update_reasoning_ui_show_only_latest_presence_in_pending_state branch from b5cebd1 to 293b246 Compare May 1, 2025 18:10
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 1, 2025 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 1, 2025 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 1, 2025 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 1, 2025 18:10 Inactive
@graphite-app graphite-app bot merged commit 293b246 into main May 1, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 05-01-nebula_update_reasoning_ui_show_only_latest_presence_in_pending_state branch May 1, 2025 18:17
@vercel vercel bot temporarily deployed to Production – docs-v2 May 1, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Production – login May 1, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 1, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 1, 2025 18:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls