Skip to content

[SDK] Handle environments where process is not defined #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

[SDK] Handle environments where process is not defined #7809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-lamps-post.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Handle environments where process is not defined
4 changes: 3 additions & 1 deletion packages/thirdweb/src/utils/any-evm/zksync/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
export const CONTRACT_DEPLOYER_ADDRESS =
"0x0000000000000000000000000000000000008006" as const;
export const KNOWN_CODES_STORAGE = "0x0000000000000000000000000000000000008004";
export const PUBLISHED_PRIVATE_KEY = process.env.ZKSYNC_PUBLISHED_PRIVATE_KEY;
export const PUBLISHED_PRIVATE_KEY = process
? process.env.ZKSYNC_PUBLISHED_PRIVATE_KEY
: undefined;

Check warning on line 8 in packages/thirdweb/src/utils/any-evm/zksync/constants.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/utils/any-evm/zksync/constants.ts#L8 

Added line #L8 was not covered by tests

export const singletonFactoryAbi = [
"function deploy(bytes32,bytes32,bytes) external payable",
Expand Down
5 changes: 3 additions & 2 deletions packages/thirdweb/src/utils/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export const IS_DEV =
process.env.NODE_ENV === "development" || process.env.NODE_ENV === "test";
process &&
(process.env.NODE_ENV === "development" || process.env.NODE_ENV === "test");

export const IS_TEST = process.env.NODE_ENV === "test";
export const IS_TEST = process && process.env.NODE_ENV === "test";
Loading