-
Notifications
You must be signed in to change notification settings - Fork 619
Remove "dedicated" from engine URLs #7897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Caution Review failedThe pull request is closed. WalkthroughUpdated engine navigation base path across dashboard components from /engine/dedicated to /engine, affecting link generation, sidebar roots, permission error redirects, and post-import navigation. No logic, UI, or exported API signatures were changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as Dashboard UI
participant Mut as importEngine()
participant Router
User->>UI: Click "Import Engine"
UI->>Mut: mutate(import config)
Mut-->>UI: success
note over UI,Router: Updated redirect base path
UI->>Router: navigate to /team/{team}/{project}/engine
Router-->>User: Engine page rendered
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7897 +/- ##
=======================================
Coverage 56.53% 56.53%
=======================================
Files 904 904
Lines 58592 58592
Branches 4143 4143
=======================================
Hits 33126 33126
Misses 25360 25360
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|

TL;DR
Updated engine URL paths by removing the
/dedicatedsegment from all engine-related navigation links.What changed?
Modified the engine URL path structure across multiple components by removing the
/dedicatedsegment from the path. The changes affect:All paths now use the simplified format:
/team/{team_slug}/{project_slug}/engineinstead of/team/{team_slug}/{project_slug}/engine/dedicated.How to test?
Why make this change?
This change simplifies the URL structure for engine-related pages, making the paths more intuitive and consistent. Removing the
/dedicatedsegment streamlines navigation and creates a cleaner URL hierarchy.Summary by CodeRabbit