Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Aug 21, 2025

TL;DR

Updated engine URL paths by removing the /dedicated segment from all engine-related navigation links.

What changed?

Modified the engine URL path structure across multiple components by removing the /dedicated segment from the path. The changes affect:

  • Engine info section navigation links
  • Import engine redirect path
  • Engine instances list links
  • Engine sidebar layout paths
  • Engine permission check paths

All paths now use the simplified format: /team/{team_slug}/{project_slug}/engine instead of /team/{team_slug}/{project_slug}/engine/dedicated.

How to test?

  1. Navigate to the engine pages for a project
  2. Verify all links work correctly with the new URL structure
  3. Test the import engine functionality to ensure it redirects to the correct page
  4. Check that the sidebar navigation works properly with the updated paths

Why make this change?

This change simplifies the URL structure for engine-related pages, making the paths more intuitive and consistent. Removing the /dedicated segment streamlines navigation and creates a cleaner URL hierarchy.

Summary by CodeRabbit

  • Refactor
    • Consolidated engine URLs from “/engine/dedicated” to “/engine” across the dashboard for consistent navigation.
    • Updated the “Try Demo Engine” link to the new engine path.
    • After importing an engine, redirects now land on the unified engine page.
    • Sidebar and engine list/table links now point to the new engine paths per instance.
    • Error and permission flows route to the updated engine base path.

@vercel
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Aug 21, 2025 4:33pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Aug 21, 2025 4:33pm
nebula Skipped Skipped Aug 21, 2025 4:33pm
thirdweb_playground Skipped Skipped Aug 21, 2025 4:33pm
wallet-ui Skipped Skipped Aug 21, 2025 4:33pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 2e23e37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui August 21, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula August 21, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 21, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 21, 2025 16:25 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated engine navigation base path across dashboard components from /engine/dedicated to /engine, affecting link generation, sidebar roots, permission error redirects, and post-import navigation. No logic, UI, or exported API signatures were changed.

Changes

Cohort / File(s) Summary
Engine base-path update (general/overview)
apps/dashboard/.../engine/(general)/_components.tsx, apps/dashboard/.../engine/(general)/import/import-engine-dialog.tsx, apps/dashboard/.../engine/(general)/overview/engine-list.tsx
Replaced engineLinkPrefix/navigation targets from /engine/dedicated to /engine for demo links, import success redirect, and engine list item links.
Engine base-path update (instance pages)
apps/dashboard/.../engine/(instance)/[engineId]/_components/EnginePageLayout.tsx, apps/dashboard/.../engine/(instance)/[engineId]/_components/EnsureEnginePermission.tsx
Updated rootPath used for sidebar link construction and error page navigation from /engine/dedicated to /engine.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as Dashboard UI
  participant Mut as importEngine()
  participant Router

  User->>UI: Click "Import Engine"
  UI->>Mut: mutate(import config)
  Mut-->>UI: success
  note over UI,Router: Updated redirect base path
  UI->>Router: navigate to /team/{team}/{project}/engine
  Router-->>User: Engine page rendered
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d12249 and 2e23e37.

📒 Files selected for processing (5)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(general)/_components.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(general)/import/import-engine-dialog.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(general)/overview/engine-list.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(instance)/[engineId]/_components/EnginePageLayout.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(instance)/[engineId]/_components/EnsureEnginePermission.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Remove_dedicated_from_engine_URLs

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Aug 21, 2025
Copy link
Member Author

jnsdls commented Aug 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review August 21, 2025 16:27
@jnsdls jnsdls requested review from a team as code owners August 21, 2025 16:27
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.53%. Comparing base (2d12249) to head (2e23e37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7897   +/-   ##
=======================================
  Coverage   56.53%   56.53%           
=======================================
  Files         904      904           
  Lines       58592    58592           
  Branches     4143     4143           
=======================================
  Hits        33126    33126           
  Misses      25360    25360           
  Partials      106      106           
Flag Coverage Δ
packages 56.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jnsdls jnsdls merged commit b075ff5 into main Aug 21, 2025
24 of 26 checks passed
@jnsdls jnsdls deleted the Remove_dedicated_from_engine_URLs branch August 21, 2025 16:28
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.06 KB (0%) 1.3 s (0%) 276 ms (+268.24% 🔺) 1.6 s
thirdweb (cjs) 357.05 KB (0%) 7.2 s (0%) 694 ms (+18.09% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 140 ms (+2961.94% 🔺) 254 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 122 ms (+9007% 🔺) 132 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 78 ms (+699.11% 🔺) 461 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants