deprecated and redirected docs #7960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
Contributor
WalkthroughRemoves the entire Infrastructure section (layout, sidebar, and associated MDX pages for Storage and RPC Edge) and adds two wildcard redirects routing infrastructure storage and rpc-edge paths to external portal documentation. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Portal as Portal App
participant Redirects as Redirects
participant External as External Portal
User->>Portal: GET /infrastructure/storage/...
Portal->>Redirects: match rules
alt matches /infrastructure/storage/:path*
Redirects-->>Portal: 302 Location: https://portal.thirdweb.com/...#storage
else matches /infrastructure/rpc-edge/:path*
Redirects-->>Portal: 302 Location: https://portal.thirdweb.com/...#rpc
else
Redirects-->>Portal: no redirect (normal routing)
end
Portal-->>User: HTTP redirect response
User->>External: Follow redirect
External-->>User: Serve external doc page
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (10)
💤 Files with no reviewable changes (9)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
the
Portal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7960 +/- ##
=======================================
Coverage 56.52% 56.52%
=======================================
Files 904 904
Lines 58623 58623
Branches 4146 4146
=======================================
Hits 33138 33138
Misses 25380 25380
Partials 105 105
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/redirects.mjs (1)
868-872: External wildcard redirects added — verify anchors and avoid double-hop chains
- These rules look fine, but existing redirects (e.g., Line 858–866 for
/rpc-edgeand/storage/*) will cause two-hop redirects (legacy path →/infrastructure/...→ external). If you want single-hop, either move these entries above the older ones or update the older/rpc-edge/*and/storage/*rules to point directly to the external targets.- Please confirm the external anchors
#storageand#rpcexist and are stable. If uncertain, consider making these temporary (non-permanent) until finalized to avoid long-lived 308 caches.Happy to propose a small follow-up diff that reorders or consolidates the rules to ensure single-hop behavior and, if desired, makes these two redirects temporary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (9)
apps/portal/src/app/infrastructure/assets/test.jpgis excluded by!**/*.jpgapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/api-key.pngis excluded by!**/*.pngapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/public-rpcs.pngis excluded by!**/*.pngapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/usage-dashboard.pngis excluded by!**/*.pngapps/portal/src/app/infrastructure/rpc-edge/overview/assets/rpc-diagram.svgis excluded by!**/*.svgapps/portal/src/app/infrastructure/storage/how-storage-works/assets/storage-diagram.svgis excluded by!**/*.svgapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-dashboard.pngis excluded by!**/*.pngapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-upload.pngis excluded by!**/*.pngapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-urls.pngis excluded by!**/*.png
📒 Files selected for processing (10)
apps/portal/redirects.mjs(1 hunks)apps/portal/src/app/infrastructure/layout.tsx(0 hunks)apps/portal/src/app/infrastructure/page.mdx(0 hunks)apps/portal/src/app/infrastructure/rpc-edge/get-started/page.mdx(0 hunks)apps/portal/src/app/infrastructure/rpc-edge/overview/page.mdx(0 hunks)apps/portal/src/app/infrastructure/sidebar.tsx(0 hunks)apps/portal/src/app/infrastructure/storage/how-storage-works/page.mdx(0 hunks)apps/portal/src/app/infrastructure/storage/how-to-use-storage/host-web-app/page.mdx(0 hunks)apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/page.mdx(0 hunks)apps/portal/src/app/infrastructure/storage/overview/page.mdx(0 hunks)
💤 Files with no reviewable changes (9)
- apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/page.mdx
- apps/portal/src/app/infrastructure/rpc-edge/get-started/page.mdx
- apps/portal/src/app/infrastructure/sidebar.tsx
- apps/portal/src/app/infrastructure/storage/how-to-use-storage/host-web-app/page.mdx
- apps/portal/src/app/infrastructure/rpc-edge/overview/page.mdx
- apps/portal/src/app/infrastructure/storage/how-storage-works/page.mdx
- apps/portal/src/app/infrastructure/storage/overview/page.mdx
- apps/portal/src/app/infrastructure/page.mdx
- apps/portal/src/app/infrastructure/layout.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Sep 2, 2025
Contributor
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on removing several files related to the `infrastructure` section of the application, including markdown files, images, and TypeScript components, while also updating the `redirects.mjs` file to include new external portal redirects.
### Detailed summary
- Deleted the following files:
- `apps/portal/src/app/infrastructure/page.mdx`
- `apps/portal/src/app/infrastructure/layout.tsx`
- `apps/portal/src/app/infrastructure/sidebar.tsx`
- `apps/portal/src/app/infrastructure/assets/test.jpg`
- `apps/portal/src/app/infrastructure/storage/overview/page.mdx`
- `apps/portal/src/app/infrastructure/rpc-edge/overview/page.mdx`
- `apps/portal/src/app/infrastructure/rpc-edge/get-started/page.mdx`
- `apps/portal/src/app/infrastructure/storage/how-storage-works/page.mdx`
- `apps/portal/src/app/infrastructure/rpc-edge/get-started/assets/api-key.png`
- `apps/portal/src/app/infrastructure/rpc-edge/overview/assets/rpc-diagram.svg`
- `apps/portal/src/app/infrastructure/rpc-edge/get-started/assets/public-rpcs.png`
- `apps/portal/src/app/infrastructure/rpc-edge/get-started/assets/usage-dashboard.png`
- `apps/portal/src/app/infrastructure/storage/how-to-use-storage/host-web-app/page.mdx`
- `apps/portal/src/app/infrastructure/storage/how-storage-works/assets/storage-diagram.svg`
- `apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/page.mdx`
- `apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-urls.png`
- `apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-upload.png`
- `apps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-dashboard.png`
- Updated `apps/portal/redirects.mjs` to:
- Redirect `"/storage/upload-to-ipfs"` to `"/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs"`
- Add infrastructure redirects to external portal links for `"/infrastructure/storage/:path*"` and `"/infrastructure/rpc-edge/:path*"`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- Documentation
- Removed the Infrastructure section from the portal, including Overview, Storage (Overview, How Storage Works, Upload Files to IPFS, Host Web App), and RPC Edge (Overview, Get Started) pages.
- Updated navigation accordingly to reflect the removal of these pages.
- New Features
- Added automatic redirects for Infrastructure content:
- /infrastructure/storage/:path* now points to the external Storage documentation.
- /infrastructure/rpc-edge/:path* now points to the external RPC documentation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
deprecate-rpc-storage
branch
from
baa39e6 to
aadaf20
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on the deletion of various files related to the
infrastructuresection of the application, along with updates to theredirects.mjsfile to include new redirect paths to external resources.Detailed summary
apps/portal/src/app/infrastructure/page.mdxapps/portal/src/app/infrastructure/layout.tsxapps/portal/src/app/infrastructure/sidebar.tsxapps/portal/src/app/infrastructure/assets/test.jpgapps/portal/src/app/infrastructure/storage/overview/page.mdxapps/portal/src/app/infrastructure/rpc-edge/overview/page.mdxapps/portal/src/app/infrastructure/rpc-edge/get-started/page.mdxapps/portal/src/app/infrastructure/storage/how-storage-works/page.mdxapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/api-key.pngapps/portal/src/app/infrastructure/rpc-edge/overview/assets/rpc-diagram.svgapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/public-rpcs.pngapps/portal/src/app/infrastructure/rpc-edge/get-started/assets/usage-dashboard.pngapps/portal/src/app/infrastructure/storage/how-to-use-storage/host-web-app/page.mdxapps/portal/src/app/infrastructure/storage/how-storage-works/assets/storage-diagram.svgapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/page.mdxapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-urls.pngapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-upload.pngapps/portal/src/app/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs/assets/storage-dashboard.pngredirects.mjs:"/storage/upload-to-ipfs"to"/infrastructure/storage/how-to-use-storage/upload-files-to-ipfs""/infrastructure/storage/:path*"and"/infrastructure/rpc-edge/:path*"Summary by CodeRabbit
Documentation
New Features