[Portal] docs: fix broken link #7962
Conversation
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
@VolodymyrBg is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughA single Markdown link in the Modular Contract section was changed: the href was updated from an external URL to an internal relative path; no other content, code, or exported entities were modified. Changes
Sequence Diagram(s)No sequence diagram necessary for this documentation-only change. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
the
Portal
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx(1 hunks)
| ### Modular Contract | ||
|
|
||
| This contract is created using the modular contract framework. Modules on this contract are upgradeable. [Learn more about Modular Contracts.](https://portal.thirdweb.com/contracts/modular-contracts/overview) | ||
| This contract is created using the modular contract framework. Modules on this contract are upgradeable. [Learn more about Modular Contracts.](https://portal.thirdweb.com/contracts/modular-contracts) |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Good fix: link now targets the live Modular Contracts page
Confirmed the destination resolves. (portal.thirdweb.com)
Optional follow-ups:
- Prefer a relative href (/contracts/modular-contracts) to avoid hardcoding the domain and to work in preview/staging.
- Add a docs redirect from /contracts/modular-contracts/overview → /contracts/modular-contracts to prevent future 404s.
- Quick scan for other occurrences of the old URL:
🏁 Script executed:
#!/bin/bash
# find lingering references to the 404 path
rg -n -S 'portal\.thirdweb\.com/contracts/modular-contracts/overview|/contracts/modular-contracts/overview' -g '!**/node_modules/**'Length of output: 1893
Replace all /contracts/modular-contracts/overview links with the canonical /contracts/modular-contracts path
- Update the MDX files under apps/portal/src/app/tokens/explore/pre-built-modular/ (token-drop, edition-drop, nft-collection, nft-drop, edition, open-edition) to use
[Learn more about Modular Contracts.](/contracts/modular-contracts) - Update the TSX link in apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/contracts/page.tsx
- Add a redirect from
/contracts/modular-contracts/overview→/contracts/modular-contractsin the docs routing config to prevent future 404s
🤖 Prompt for AI Agents
In apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx around
line 77, replace the existing Learn more link path
/contracts/modular-contracts/overview with the canonical
/contracts/modular-contracts; do the same across the other MDX files in
apps/portal/src/app/tokens/explore/pre-built-modular (token-drop, edition-drop,
nft-collection, nft-drop, edition, open-edition). Also update the TSX link in
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/contracts/page.tsx
to point to /contracts/modular-contracts instead of the /overview path, and add
a redirect rule in the docs routing config (where routes are defined) that maps
/contracts/modular-contracts/overview → /contracts/modular-contracts to prevent
404s.
apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx
Outdated
Show resolved
Hide resolved
…e.mdx Signed-off-by: Joaquim Verges <joaquim.verges@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7962 +/- ##
===========================================
- Coverage 56.52% 36.43% -20.10%
===========================================
Files 904 897 -7
Lines 58623 58126 -497
Branches 4146 2328 -1818
===========================================
- Hits 33138 21179 -11959
- Misses 25380 36874 +11494
+ Partials 105 73 -32
🚀 New features to boost your workflow:
|
2 participants
https://portal.thirdweb.com/contracts/modular-contracts/overview - 404
https://portal.thirdweb.com/contracts/modular-contracts - works
PR-Codex overview
This PR updates a link in the
page.mdxfile related to the modular contract framework, changing the URL to point to a relative path instead of an absolute one.Detailed summary
Modular Contractsection from an absolute URL (https://portal.thirdweb.com/contracts/modular-contracts/overview) to a relative URL (/contracts/modular-contracts).Summary by CodeRabbit