Version Packages #8008
Merged
Version Packages #8008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughRemoved one changeset entry and added/updated changelog and package version metadata for packages thirdweb, nebula, and wagmi-adapter. No code or public API changes were introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/wagmi-adapter/package.json (1)
1-59: Add a size-limit budget for this package.Repo guidelines track bundle budgets via package.json#size-limit. This package lacks a size-limit config/script, unlike others (e.g., thirdweb). Add in a follow-up to prevent regressions.
Proposed snippet:
"devDependencies": { "@biomejs/biome": "2.0.6", "@wagmi/core": "2.17.3", "rimraf": "6.0.1", - "thirdweb": "workspace:*" + "thirdweb": "workspace:*", + "size-limit": "11.2.0" }, ... "scripts": { "build": "pnpm clean && pnpm build:cjs && pnpm build:esm && pnpm build:types", ... - "lint": "biome check ./src" + "lint": "biome check ./src", + "size": "size-limit" }, + "size-limit": [ + { + "path": "dist/esm/exports/thirdweb.js", + "limit": "15 KB" + } + ],packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Tiny note: clarify “no code changes.”Add a one-liner under 0.2.139 like “No code changes; version alignment.” for reader clarity.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry looks accurate.Optional: append “No code changes; dependency bump only.” to make it explicit.
packages/thirdweb/CHANGELOG.md (1)
7-8: Tighten wording and avoid bare URL (markdownlint MD034).
- Prefer sentence case and correct spacing: “Polygon Amoy gas station URL fix.”
- Replace the bare URL with a GitHub-native reference “Related: #8004” to satisfy MD034 and match prior style.
Apply this diff:
- - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon amoy gasstation url fix - https://github.com/thirdweb-dev/js/pull/8004 + - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon Amoy gas station URL fix. Related: #8004
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/huge-bees-tan.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/huge-bees-tan.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.jsonpackages/nebula/package.jsonpackages/wagmi-adapter/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (3)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
packages/thirdweb/CHANGELOG.md
8-8: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
58-58: Version bump looks good.No API surface touched; safe patch publish.
packages/nebula/package.json (1)
60-60: Version bump is consistent with dependent thirdweb@5.105.42.No other changes; OK to publish.
packages/thirdweb/package.json (1)
420-420: Patch version bump only — OK.Scripts and size-limit already present; nothing else to do.
packages/thirdweb/CHANGELOG.md (1)
3-6: Changelog structure LGTM.Version header and “Patch Changes” section follow existing conventions. No other issues spotted.
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
d49f021 to
d645ac6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
7-8: Tidy wording + fix bare URL (markdownlint MD034).
- Capitalize “Amoy” and “gas station”; capitalize “URL”.
- Replace the bare URL with a Markdown link appended to the bullet to satisfy MD034.
Suggested edit:
- - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon amoy gasstation url fix - https://github.com/thirdweb-dev/js/pull/8004 + - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon Amoy gas station URL fix. See [#8004](https://github.com/thirdweb-dev/js/pull/8004).If you prefer to keep the original PR title verbatim, at least wrap the bare URL as
<https://github.com/thirdweb-dev/js/pull/8004>to avoid MD034.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/huge-bees-tan.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/huge-bees-tan.md
✅ Files skipped from review due to trivial changes (1)
- packages/wagmi-adapter/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/thirdweb/package.json
- packages/wagmi-adapter/package.json
- packages/nebula/package.json
- packages/nebula/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
packages/thirdweb/CHANGELOG.md
8-8: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-6: LGTM — entry structure and references look correct.Version header and “Patch Changes” section match the file’s existing format.
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
d645ac6 to
79f4221
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
7-7: Unify tense/style with surrounding entries (“Adds” vs “Added”).Most bullets in recent sections use present tense (“Adds”, “Fix”), not past (“Added”). Align this item for consistency.
- - [#7973](https://github.com/thirdweb-dev/js/pull/7973) [`b149019`](https://github.com/thirdweb-dev/js/commit/b149019318a3a9f73aab96b68a92daef41a961e2) Thanks [@shubham-yuga](https://github.com/shubham-yuga)! - Added Glyph wallet to supported wallets + - [#7973](https://github.com/thirdweb-dev/js/pull/7973) [`b149019`](https://github.com/thirdweb-dev/js/commit/b149019318a3a9f73aab96b68a92daef41a961e2) Thanks [@shubham-yuga](https://github.com/shubham-yuga)! - Adds Glyph wallet to supported wallets
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/huge-bees-tan.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/huge-bees-tan.md
✅ Files skipped from review due to trivial changes (2)
- packages/wagmi-adapter/package.json
- packages/nebula/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/package.json
- packages/thirdweb/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
packages/thirdweb/CHANGELOG.md
10-10: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
Comment on lines
+9
to
+10
| - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon amoy gasstation url fix | ||
| https://github.com/thirdweb-dev/js/pull/8004 |
There was a problem hiding this comment.
Fix grammar/capitalization and avoid bare URL; fold reference into the bullet.
Current text reads awkwardly (“amoy gasstation url fix”) and the lone bare URL violates MD034. Suggest rewording and inlining the reference.
- - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon amoy gasstation url fix
- https://github.com/thirdweb-dev/js/pull/8004
+ - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Fix Polygon Amoy gas station URL (references [#8004](https://github.com/thirdweb-dev/js/pull/8004))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Polygon amoy gasstation url fix | |
| https://github.com/thirdweb-dev/js/pull/8004 | |
| - [#8007](https://github.com/thirdweb-dev/js/pull/8007) [`4ff1cf7`](https://github.com/thirdweb-dev/js/commit/4ff1cf79794af0c2e52f4beacbcf0d5d69266365) Thanks [@nischitpra](https://github.com/nischitpra)! - Fix Polygon Amoy gas station URL (references [#8004](https://github.com/thirdweb-dev/js/pull/8004)) |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around lines 9 to 10, the changelog entry
contains poor grammar/capitalization ("amoy gasstation url fix"), a bare URL
(MD034), and an extra separate PR link; reword the bullet to use proper
capitalization and grammar (e.g., "Fix Polygon Amoy Gas Station URL"), fold the
PR reference into the same bullet as an inline link (use the PR number or commit
hash as the link text), and remove the standalone bare URL so the entry is a
single polished sentence with an inline link to the PR/commit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8008 +/- ##
==========================================
- Coverage 56.63% 56.62% -0.02%
==========================================
Files 904 904
Lines 58677 58677
Branches 4160 4161 +1
==========================================
- Hits 33231 33225 -6
- Misses 25340 25346 +6
Partials 106 106
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.42
Patch Changes
b149019,4ff1cf7]:thirdweb@5.105.42
Patch Changes
#7973
b149019Thanks @shubham-yuga! - Added Glyph wallet to supported wallets#8007
4ff1cf7Thanks @nischitpra! - Polygon amoy gasstation url fixpolygon amoy gasstation update #8004
@thirdweb-dev/wagmi-adapter@0.2.139
PR-Codex overview
This PR focuses on updating version numbers across several packages and adding new changelog entries for
thirdweb,nebula, andwagmi-adapter, reflecting recent changes and dependency updates.Detailed summary
.changeset/huge-bees-tan.mdand.changeset/cold-spiders-open.md.versioninpackages/thirdweb/package.jsonfrom5.105.41to5.105.42.versioninpackages/nebula/package.jsonfrom0.2.41to0.2.42.versioninpackages/wagmi-adapter/package.jsonfrom0.2.138to0.2.139.nebulaandthirdwebwith new features and fixes.Summary by CodeRabbit