Skip to content

[SDK] Support full MetaMask disconnection on wallet disconnect #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

[SDK] Support full MetaMask disconnection on wallet disconnect #8039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/petite-lizards-create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Support fully disconnecting from metamask on disconnect
3 changes: 2 additions & 1 deletion packages/thirdweb/src/extensions/erc721/read/getNFT.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ describe.runIf(process.env.TW_SECRET_KEY)("erc721.getNFT", () => {
`);
});

it("with owner using indexer", async () => {
// skip until indexer restores owner functionality
it.skip("with owner using indexer", async () => {
const nft = await getNFT({
contract: { ...DOODLES_CONTRACT },
includeOwner: true,
Expand Down
15 changes: 15 additions & 0 deletions packages/thirdweb/src/wallets/injected/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
serializeTypedData,
stringify,
validateTypedData,
withTimeout,
} from "viem";
import { isInsufficientFundsError } from "../../analytics/track/helpers.js";
import {
Expand Down Expand Up @@ -400,6 +401,20 @@ async function onConnect({
provider.removeListener("accountsChanged", onAccountsChanged);
provider.removeListener("chainChanged", onChainChanged);
provider.removeListener("disconnect", onDisconnect);

// Experimental support for MetaMask disconnect
// https://github.com/MetaMask/metamask-improvement-proposals/blob/main/MIPs/mip-2.md
try {
// Adding timeout as not all wallets support this method and can hang
await withTimeout(
() =>
provider.request({
method: "wallet_revokePermissions",
params: [{ eth_accounts: {} }],
}),
{ timeout: 100 },
);
} catch {}
}

async function onDisconnect() {
Expand Down
Loading