Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 14, 2025


PR-Codex overview

This PR introduces a deprecation banner on the NebulaLoginPage to inform users that the service will be deprecated on September 30, 2025, and provides instructions for transitioning to thirdweb AI.

Detailed summary

  • Added a deprecation banner to the NebulaLoginPage.
  • The banner includes:
    • Announcement of the transition to thirdweb AI.
    • Deadline for deprecation (September 30, 2025).
    • Instructions for signing into the thirdweb dashboard and creating a new project.
    • Reminder to withdraw any remaining funds from Nebula account.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added a permanent deprecation notice on the logged-out/login page. The banner includes a headline with a link to thirdweb AI, a deprecation date, and guidance on next steps: sign in to the dashboard to create a new project and withdraw any remaining Nebula funds before the deadline. The existing welcome/connect flow remains unchanged.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 14, 2025 23:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 14, 2025 23:51 Inactive
@vercel
Copy link

vercel bot commented Sep 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nebula Ready Ready Preview Comment Sep 15, 2025 0:05am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 15, 2025 0:05am
thirdweb_playground Skipped Skipped Sep 15, 2025 0:05am
thirdweb-www Skipped Skipped Sep 15, 2025 0:05am
wallet-ui Skipped Skipped Sep 15, 2025 0:05am

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 14, 2025 23:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 14, 2025 23:51 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2025

⚠️ No Changeset found

Latest commit: 15f2205

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 14, 2025

Walkthrough

Adds an always-visible deprecation banner to the NebulaLoggedOutStatePage (Nebula login page) immediately after the header. The banner shows a linked heading, a deprecation date, and two guidance paragraphs. No state, API, or control-flow changes; existing connect/welcome logic is unchanged.

Changes

Cohort / File(s) Summary
Nebula login page UI
apps/nebula/src/app/login/NebulaLoginPage.tsx
Inserted an unconditional deprecation banner JSX block (destructive-styled container) immediately after the header containing a linked heading to thirdweb AI, a deprecation date, and two guidance paragraphs. No props, state, or branching logic modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR body includes the repository template comment and a PR-Codex overview that summarizes the deprecation banner, deadline, and migration instructions, but it does not populate the required template sections "Notes for the reviewer" and "How to test" nor does it include an issue tag or explicit testing steps. Because those template sections are missing and no concrete test instructions are provided, the description does not meet the repository's template requirements. This prevents reviewers from easily validating behavior and testing the change. Populate the repository template in the PR body: add the formatted title line and issue tag if applicable, add a "Notes for the reviewer" section describing the banner behavior, deadline, and relevant links, and add a "How to test" section with concrete manual verification steps and any test commands. Include the deprecation date and the dashboard/thirdweb AI links referenced in the PR-Codex to make validation straightforward. After adding these items the description will meet the template and facilitate reviewer validation.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[Nebula] Add deprecation banner with migration information" succinctly and accurately summarizes the primary change — adding a deprecation/migration banner to the Nebula login page (NebulaLoginPage). It is concise, uses the bracketed scope prefix, and highlights the main user-facing change without extraneous details. Therefore it meets the repository's expectations for a clear, scan-friendly PR title.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Nebula_Add_deprecation_banner_with_migration_information

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between de3d7c9 and 15f2205.

📒 Files selected for processing (1)
  • apps/nebula/src/app/login/NebulaLoginPage.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/nebula/src/app/login/NebulaLoginPage.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.53%. Comparing base (59d2265) to head (15f2205).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8051   +/-   ##
=======================================
  Coverage   56.53%   56.53%           
=======================================
  Files         904      904           
  Lines       58864    58864           
  Branches     4166     4166           
=======================================
  Hits        33280    33280           
  Misses      25478    25478           
  Partials      106      106           
Flag Coverage Δ
packages 56.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges marked this pull request as ready for review September 14, 2025 23:53
@joaquim-verges joaquim-verges requested review from a team as code owners September 14, 2025 23:53
@joaquim-verges joaquim-verges force-pushed the _Nebula_Add_deprecation_banner_with_migration_information branch from de3d7c9 to 667d998 Compare September 14, 2025 23:55
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 14, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 14, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 14, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 14, 2025 23:55 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.96 KB (0%) 1.3 s (0%) 240 ms (+192.5% 🔺) 1.6 s
thirdweb (cjs) 361.44 KB (0%) 7.3 s (0%) 832 ms (+16.69% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 107 ms (+3328.62% 🔺) 222 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 43 ms (+1644.82% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 70 ms (+1696.13% 🔺) 453 ms

@joaquim-verges joaquim-verges force-pushed the _Nebula_Add_deprecation_banner_with_migration_information branch from 667d998 to 15f2205 Compare September 15, 2025 00:04
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 15, 2025 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 15, 2025 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 15, 2025 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 15, 2025 00:04 Inactive
@joaquim-verges joaquim-verges merged commit f9bbf81 into main Sep 15, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Nebula_Add_deprecation_banner_with_migration_information branch September 15, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants