-
Notifications
You must be signed in to change notification settings - Fork 618
[MNY-203] Dashboard: ERC20 token page title, metadata and OG updates #8194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -190,25 +190,37 @@ export async function generateContractLayoutMetadata(params: { | |||||
| .replace("Testnet", "") | ||||||
| .trim(); | ||||||
|
|
||||||
| const title = `${contractDisplayName} | ${cleanedChainName} Smart Contract`; | ||||||
| let title = `${contractDisplayName} | ${cleanedChainName} Smart Contract`; | ||||||
| let description = ""; | ||||||
|
|
||||||
| if (isERC721 || isERC1155) { | ||||||
| description = `View tokens, source code, transactions, balances, and analytics for the ${contractDisplayName} smart contract on ${cleanedChainName}.`; | ||||||
| } else if (isERC20) { | ||||||
| description = `View ERC20 tokens, transactions, balances, source code, and analytics for the ${contractDisplayName} smart contract on ${cleanedChainName}`; | ||||||
| title = `${contractMetadata.name} (${contractMetadata.symbol}) on ${cleanedChainName} | Buy, Swap, Bridge & Price`; | ||||||
| description = `Buy, swap & bridge ${contractMetadata.name} (${contractMetadata.symbol}) on ${cleanedChainName} with thirdweb Bridge. View contract address, holders, analytics, transactions and live price.`; | ||||||
| } else { | ||||||
| description = `View tokens, transactions, balances, source code, and analytics for the ${contractDisplayName} smart contract on ${cleanedChainName}`; | ||||||
| description = `View tokens, transactions, balances, source code, and analytics for the ${contractMetadata.name} smart contract on ${cleanedChainName}`; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the double space typo. The description contains a double space before "on": "smart contract on". This affects the text quality of user-facing metadata. Apply this diff to fix the typo: - description = `View tokens, transactions, balances, source code, and analytics for the ${contractMetadata.name} smart contract on ${cleanedChainName}`;
+ description = `View tokens, transactions, balances, source code, and analytics for the ${contractMetadata.name} smart contract on ${cleanedChainName}`;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
|
|
||||||
| return { | ||||||
| description: description, | ||||||
| title: title, | ||||||
| openGraph: { | ||||||
| description: description, | ||||||
| title: title, | ||||||
| }, | ||||||
| }; | ||||||
| } catch { | ||||||
| const fallbackTitle = `${shortenIfAddress(params.contractAddress)} | ${params.chainIdOrSlug}`; | ||||||
| const fallbackDescription = `View tokens, transactions, balances, source code, and analytics for the smart contract on Chain ID ${params.chainIdOrSlug}`; | ||||||
|
|
||||||
| return { | ||||||
| description: `View tokens, transactions, balances, source code, and analytics for the smart contract on Chain ID ${params.chainIdOrSlug}`, | ||||||
| title: `${shortenIfAddress(params.contractAddress)} | ${params.chainIdOrSlug}`, | ||||||
| description: fallbackDescription, | ||||||
| title: fallbackTitle, | ||||||
| openGraph: { | ||||||
| description: fallbackDescription, | ||||||
| title: fallbackTitle, | ||||||
| }, | ||||||
MananTank marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| }; | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.