[MNY-235] Dashboard: Fix payment page theme issues #8199
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
WalkthroughApplied ThemeProvider at page level for /pay and /pay/[id], removed ThemeProvider from the pay layout, and refactored PayPageWidget to derive SDK theme via useTheme/getSDKTheme (prop removed). Header/details rendering in /pay/[id] was reorganized inside the themed wrapper; rendering and data flow otherwise unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Page as /pay or /pay/[id] page
participant ThemeProv as ThemeProvider
participant PayWidget as PayPageWidget
participant Checkout as CheckoutWidget
User->>Page: Request page
Page->>ThemeProv: Wrap render tree (forcedTheme)
ThemeProv->>PayWidget: Provide theme context
PayWidget->>ThemeProv: useTheme() reads current theme
PayWidget->>Checkout: Render with getSDKTheme(theme)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8199 +/- ##
=======================================
Coverage 55.04% 55.04%
=======================================
Files 919 919
Lines 60563 60563
Branches 4125 4125
=======================================
Hits 33338 33338
Misses 27121 27121
Partials 104 104
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/dashboard/src/app/pay/page.tsx (1)
37-46: Consider extracting the ThemeProvider wrapper to reduce duplication.The same ThemeProvider configuration appears in both render paths. Consider extracting it to a wrapper component or moving it higher in the component tree to avoid repetition.
Example refactor:
export default async function PayPage({ searchParams, }: { searchParams: Promise<PayParams>; }) { const params = await searchParams; + + // Determine content based on params + const content = !params.chainId && + !params.recipientAddress && + !params.tokenAddress && + !params.amount ? ( + <PaymentLinkForm /> + ) : ( + // ... existing validation and PayPageWidget render + ); - // If no query parameters are provided, show the form - if ( - !params.chainId && - !params.recipientAddress && - !params.tokenAddress && - !params.amount - ) { - return ( - <ThemeProvider - forcedTheme={params.theme === "light" ? "light" : "dark"} - attribute="class" - disableTransitionOnChange - enableSystem={false} - > - <PaymentLinkForm /> - </ThemeProvider> - ); - } - - // ... validation logic ... - return ( <ThemeProvider forcedTheme={params.theme === "light" ? "light" : "dark"} attribute="class" disableTransitionOnChange enableSystem={false} > - <PayPageWidget - amount={BigInt(params.amount)} - chainId={Number(params.chainId)} - clientId={client.clientId} - image={params.image} - name={params.name} - purchaseData={undefined} - recipientAddress={params.recipientAddress} - redirectUri={params.redirectUri} - token={token} - /> + {content} </ThemeProvider> ); }Also applies to: 97-114
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/dashboard/src/app/pay/[id]/page.tsx(2 hunks)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx(3 hunks)apps/dashboard/src/app/pay/layout.tsx(1 hunks)apps/dashboard/src/app/pay/page.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/[id]/page.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/[id]/page.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/[id]/page.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/[id]/page.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/[id]/page.tsx
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).
Applied to files:
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx
🧬 Code graph analysis (3)
apps/dashboard/src/app/pay/page.tsx (2)
apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx (1)
PaymentLinkForm(27-357)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
PayPageWidget(15-91)
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
apps/dashboard/src/@/utils/sdk-component-theme.ts (1)
getSDKTheme(8-43)
apps/dashboard/src/app/pay/[id]/page.tsx (5)
apps/playground-web/src/app/ai/components/resolveSchemeWithErrorHandler.ts (1)
resolveSchemeWithErrorHandler(4-21)apps/dashboard/src/app/pay/constants.ts (1)
payAppThirdwebClient(59-59)apps/dashboard/src/@/constants/thirdweb.server.ts (1)
getConfiguredThirdwebClient(25-95)apps/dashboard/src/@/constants/server-envs.ts (1)
DASHBOARD_THIRDWEB_SECRET_KEY(12-13)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
PayPageWidget(15-91)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
apps/dashboard/src/app/pay/layout.tsx (1)
26-28: LGTM! Theme management moved to page level.The removal of ThemeProvider from the layout simplifies the structure and allows individual pages to control their own theme configuration. This aligns with the page-level ThemeProvider additions in the other files.
apps/dashboard/src/app/pay/[id]/page.tsx (3)
90-198: LGTM! Header section restructured with improved layout.The header section now properly displays project metadata, token details, network information, and seller address within the ThemeProvider context. The conditional rendering and responsive layout adjustments look good.
199-212: LGTM! PayPageWidget invocation updated correctly.The PayPageWidget is now rendered within the ThemeProvider wrapper and will derive its theme from the context via
useTheme(). The props remain unchanged, which maintains backward compatibility.
85-85: Verify fallback to ‘dark’ when theme is undefined. searchParams.theme is optional ("light" | "dark"), so the expression defaults to"dark"; confirm this matches UX requirements and document the default behavior if needed.apps/dashboard/src/app/pay/page.tsx (1)
39-39: Confirm fallback for undefined theme to "dark". Thethemeparam inPayParamsis optional; current logic (params.theme === "light" ? "light" : "dark") treats any non-"light"value—includingundefined—as"dark". Ensure this default is intended and document it (e.g., inPayParamsor relevant docs).
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on integrating the `ThemeProvider` from `next-themes` into multiple components within the payment module, enhancing theming support across the application.
### Detailed summary
- Removed `ThemeProvider` from `PayLayout` in `layout.tsx`.
- Added `ThemeProvider` wrapping to `PayPage` in `page.tsx`.
- Integrated `ThemeProvider` in `PayPageWidget` to manage theme settings.
- Updated theme handling logic in `PayPageWidget` to use `getSDKTheme`.
- Wrapped the main structure in `ThemeProvider` in `[id]/page.tsx`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- New Features
- Consistent light/dark theme across all Pay pages, with support for forcing a theme per link and reduced visual flicker from system theme changes.
- Style
- Refined header layout: project image, name, and description grouped; “Secured by thirdweb” badge retained.
- Improved details on large screens: clearer “Network” label with icon and chain name; seller shown as ENS or shortened address, reordered for readability.
- Refactor
- Consolidated theming at the page level for consistent behavior across views.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
mny-235
branch
from
7f5b316 to
2ebba61
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
50-50: Consider usingresolvedThemefor more reliable theme value.While the current implementation works correctly with forcedTheme, using
resolvedThemefromuseTheme()would be more explicit and aligned with next-themes best practices.Apply this diff to use resolvedTheme:
- const { theme } = useTheme(); + const { resolvedTheme } = useTheme(); const chain = useV5DashboardChain(chainId); return ( <> <AutoConnect client={ clientId ? createThirdwebClient({ clientId }) : payAppThirdwebClient } /> <CheckoutWidget - theme={getSDKTheme(theme === "light" ? "light" : "dark")} + theme={getSDKTheme(resolvedTheme === "light" ? "light" : "dark")}Based on learnings:
Use resolvedTheme when you need the actual applied theme (it reflects system when theme === 'system').
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/dashboard/src/app/pay/[id]/page.tsx(2 hunks)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx(3 hunks)apps/dashboard/src/app/pay/layout.tsx(1 hunks)apps/dashboard/src/app/pay/page.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/app/pay/[id]/page.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/app/pay/[id]/page.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/app/pay/[id]/page.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/app/pay/[id]/page.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/app/pay/[id]/page.tsxapps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsxapps/dashboard/src/app/pay/page.tsxapps/dashboard/src/app/pay/layout.tsx
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).
Applied to files:
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx
🧬 Code graph analysis (3)
apps/dashboard/src/app/pay/[id]/page.tsx (5)
apps/playground-web/src/app/ai/components/resolveSchemeWithErrorHandler.ts (1)
resolveSchemeWithErrorHandler(4-21)apps/dashboard/src/app/pay/constants.ts (1)
payAppThirdwebClient(59-59)apps/dashboard/src/@/constants/thirdweb.server.ts (1)
getConfiguredThirdwebClient(25-95)apps/dashboard/src/@/constants/server-envs.ts (1)
DASHBOARD_THIRDWEB_SECRET_KEY(12-13)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
PayPageWidget(15-91)
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
apps/dashboard/src/@/utils/sdk-component-theme.ts (1)
getSDKTheme(8-43)
apps/dashboard/src/app/pay/page.tsx (2)
apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx (1)
PaymentLinkForm(27-357)apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
PayPageWidget(15-91)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
apps/dashboard/src/app/pay/layout.tsx (1)
26-28: LGTM! ThemeProvider correctly moved to page level.The removal of ThemeProvider from the layout aligns with the page-level theming strategy implemented in page.tsx and [id]/page.tsx.
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1)
38-38: LGTM! Theme handling correctly refactored.The use of
useTheme()is appropriate for a client component, and the ThemeProvider is guaranteed to be present in the parent tree (verified in both page.tsx and [id]/page.tsx).apps/dashboard/src/app/pay/page.tsx (2)
38-46: LGTM! ThemeProvider correctly integrated.The ThemeProvider configuration is appropriate with forcedTheme ensuring consistent theming and enableSystem={false} preventing theme conflicts.
97-114: LGTM! Consistent ThemeProvider configuration.The ThemeProvider wrapping and configuration matches the PaymentLinkForm path, ensuring consistent behavior across both rendering paths.
apps/dashboard/src/app/pay/[id]/page.tsx (3)
84-89: LGTM! ThemeProvider configuration is correct.The ThemeProvider setup matches the configuration in page.tsx, ensuring consistent theming across both payment pages.
90-198: LGTM! Header restructuring preserves all functionality.The header section correctly displays project metadata, details, network information, and seller details within the themed wrapper. The conditional rendering for optional fields (image, description, amount, chain, recipient) is appropriate.
199-212: LGTM! PayPageWidget integration is correct.The PayPageWidget is correctly placed within the ThemeProvider wrapper and all required props are passed. The removal of the theme prop aligns with the component's refactored implementation that uses
useTheme().
| {recipientEnsOrAddress.ensName || | ||
| (recipientEnsOrAddress.address && ( | ||
| <div className="flex flex-col gap-1 w-full my-4"> | ||
| <span className="text-muted-foreground text-xs">Seller</span> | ||
| <div className="font-medium flex-row flex justify-between items-center w-full"> | ||
| {recipientEnsOrAddress.ensName ?? | ||
| shortenAddress(recipientEnsOrAddress.address)} | ||
| </div> | ||
| </div> | ||
| ))} |
There was a problem hiding this comment.
Fix the conditional rendering logic.
The current conditional has a logic error that will render the ENS name as raw text instead of within the styled JSX structure when an ENS name exists.
Current behavior:
- If
ensNameis truthy: renders the string directly (breaks UI) - If
ensNameis falsy butaddressexists: renders the JSX (correct)
Apply this diff to fix the logic:
- {recipientEnsOrAddress.ensName ||
- (recipientEnsOrAddress.address && (
+ {(recipientEnsOrAddress.ensName || recipientEnsOrAddress.address) && (
<div className="flex flex-col gap-1 w-full my-4">
<span className="text-muted-foreground text-xs">Seller</span>
<div className="font-medium flex-row flex justify-between items-center w-full">
{recipientEnsOrAddress.ensName ??
shortenAddress(recipientEnsOrAddress.address)}
</div>
</div>
- ))}
+ )}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {recipientEnsOrAddress.ensName || | |
| (recipientEnsOrAddress.address && ( | |
| <div className="flex flex-col gap-1 w-full my-4"> | |
| <span className="text-muted-foreground text-xs">Seller</span> | |
| <div className="font-medium flex-row flex justify-between items-center w-full"> | |
| {recipientEnsOrAddress.ensName ?? | |
| shortenAddress(recipientEnsOrAddress.address)} | |
| </div> | |
| </div> | |
| ))} | |
| {(recipientEnsOrAddress.ensName || recipientEnsOrAddress.address) && ( | |
| <div className="flex flex-col gap-1 w-full my-4"> | |
| <span className="text-muted-foreground text-xs">Seller</span> | |
| <div className="font-medium flex-row flex justify-between items-center w-full"> | |
| {recipientEnsOrAddress.ensName ?? | |
| shortenAddress(recipientEnsOrAddress.address)} | |
| </div> | |
| </div> | |
| )} |
🤖 Prompt for AI Agents
In apps/dashboard/src/app/pay/[id]/page.tsx around lines 180 to 189, the
top-level conditional currently returns the raw ensName string when ensName is
truthy instead of rendering the styled JSX; change the conditional so that the
JSX block is rendered whenever either ensName or address exists (e.g., check
recipientEnsOrAddress.ensName || recipientEnsOrAddress.address), and inside that
JSX use {recipientEnsOrAddress.ensName ??
shortenAddress(recipientEnsOrAddress.address)} to display the ENS name or the
shortened address.
PR-Codex overview
This PR focuses on integrating the
ThemeProviderfor consistent theme management across various components in thepaymodule, enhancing the user interface's responsiveness to theme changes.Detailed summary
ThemeProviderfromPayLayoutinlayout.tsx.ThemeProviderinPayPageforPaymentLinkFormandPayPageWidget.PayPageWidgetto usegetSDKThemeand removed unused theme management logic.ThemeProviderin[id]/page.tsx.Summary by CodeRabbit
New Features
Style
Refactor