-
Notifications
You must be signed in to change notification settings - Fork 618
[MNY-236] Portal: Update BridgeWidget script docs to reflect new typescript type #8200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
WalkthroughUpdated BridgeWidget documentation: the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8200 +/- ##
=======================================
Coverage 55.03% 55.03%
=======================================
Files 919 919
Lines 60562 60562
Branches 4122 4122
=======================================
Hits 33332 33332
Misses 27126 27126
Partials 104 104
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/app/bridge/bridge-widget-script/page.mdx (1)
326-335: Clarify the new defaults for optional buy fields.Now that
buy.amountandbuy.chainIdare optional, please spell out what values the widget falls back to when each is omitted. Without that detail, it’s unclear to integrators what chain/amount their users will see by default. A short note here (and/or in the Options table) would keep the docs actionable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/bridge/bridge-widget-script/page.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
size-limit report 📦
|
Merge activity
|
…script type (#8200) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on making the `buy` properties optional in the configuration for the "Buy" tab UI, enhancing flexibility by allowing users to omit certain parameters. It also updates the documentation to reflect these changes. ### Detailed summary - Changed `buy` properties (`amount`, `chainId`) from required to optional in type definitions. - Updated documentation to remove "Required" tags for `amount` and `chainId`. - Clarified descriptions for `amount`, `chainId`, and `tokenAddress` in the documentation. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Buy configuration is now optional in the bridge widget; amount and chain selection can be omitted and will use defaults. * Removed forced preset buy values, enabling more flexible initialization. * **Documentation** * Updated docs to reflect optional Buy fields and default behaviors. * Revised examples and type descriptions to indicate optional amount and chain settings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
0bf802f to
d9a138a
Compare

PR-Codex overview
This PR focuses on updating the
buyconfiguration in theBuytab of the widget, making theamountandchainIdproperties optional and refining related documentation.Detailed summary
amountandchainIdin thebuyobject to optional properties.Buytype to reflect the optional nature ofamountandchainId.amountandchainIdto remove "Required" tags and clarify their usage.Summary by CodeRabbit
New Features
Documentation