Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 6, 2025


PR-Codex overview

This PR focuses on updating the buy configuration in the Buy tab of the widget, making the amount and chainId properties optional and refining related documentation.

Detailed summary

  • Changed amount and chainId in the buy object to optional properties.
  • Updated the Buy type to reflect the optional nature of amount and chainId.
  • Revised documentation for amount and chainId to remove "Required" tags and clarify their usage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Buy configuration in the bridge widget is now optional; amount and chain selection can be omitted and defaults will apply.
    • Removed enforced preset buy values, allowing more flexible widget initialization and runtime behavior.
  • Documentation

    • Updated docs and examples to show Buy fields as optional and to explain default behaviors when omitted.

@linear
Copy link

linear bot commented Oct 6, 2025

@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 6, 2025 7:08pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Oct 6, 2025 7:08pm
thirdweb_playground Skipped Skipped Oct 6, 2025 7:08pm
thirdweb-www Skipped Skipped Oct 6, 2025 7:08pm
wallet-ui Skipped Skipped Oct 6, 2025 7:08pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 6, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 6, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 6, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 6, 2025 18:48 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: d9a138a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review October 6, 2025 18:48
@MananTank MananTank requested review from a team as code owners October 6, 2025 18:48
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Updated BridgeWidget documentation: the buy configuration on Options is now optional, and Buy's amount and chainId fields are optional. The example no longer includes a default buy config and field descriptions note default behavior when omitted.

Changes

Cohort / File(s) Summary
Docs: BridgeWidget types and examples
apps/portal/src/app/bridge/bridge-widget-script/page.mdx
Made Options.buy optional; changed Buy.amount and Buy.chainId to optional; removed default buy from the BridgeWidget.render example; updated field descriptions to reflect optionality and defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description still contains the unfilled template comments and lacks the required “## Notes for the reviewer” and “## How to test” sections, so it does not adhere to the repository’s description template. Please remove the commented template placeholders and add completed “## Notes for the reviewer” and “## How to test” sections with relevant reviewer guidance and testing instructions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly references the Portal subsystem and the linked issue and succinctly describes updating the BridgeWidget documentation to reflect new TypeScript type changes, matching the main focus of the changeset.
Linked Issues Check ✅ Passed The changes update the BridgeWidget buy configuration to make amount and chainId optional and revise the documentation accordingly, which directly satisfies the objectives of linked issue MNY-236.
Out of Scope Changes Check ✅ Passed All modifications are confined to the BridgeWidget script’s buy configuration types and related documentation, and there are no unrelated or extraneous code changes present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mny-236

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0bf802f and d9a138a.

📒 Files selected for processing (1)
  • apps/portal/src/app/bridge/bridge-widget-script/page.mdx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.03%. Comparing base (777aed1) to head (d9a138a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8200   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         919      919           
  Lines       60562    60562           
  Branches     4122     4122           
=======================================
  Hits        33332    33332           
  Misses      27126    27126           
  Partials      104      104           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/portal/src/app/bridge/bridge-widget-script/page.mdx (1)

326-335: Clarify the new defaults for optional buy fields.

Now that buy.amount and buy.chainId are optional, please spell out what values the widget falls back to when each is omitted. Without that detail, it’s unclear to integrators what chain/amount their users will see by default. A short note here (and/or in the Options table) would keep the docs actionable.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 777aed1 and 0bf802f.

📒 Files selected for processing (1)
  • apps/portal/src/app/bridge/bridge-widget-script/page.mdx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.6 KB (0%) 1.3 s (0%) 258 ms (+65.7% 🔺) 1.6 s
thirdweb (cjs) 365.75 KB (0%) 7.4 s (0%) 1.6 s (+2.91% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 57 ms (+636.89% 🔺) 172 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 64 ms (+463.88% 🔺) 74 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 61 ms (+644.01% 🔺) 444 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 6, 2025

Merge activity

…script type (#8200)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on making the `buy` properties optional in the configuration for the "Buy" tab UI, enhancing flexibility by allowing users to omit certain parameters. It also updates the documentation to reflect these changes.

### Detailed summary
- Changed `buy` properties (`amount`, `chainId`) from required to optional in type definitions.
- Updated documentation to remove "Required" tags for `amount` and `chainId`.
- Clarified descriptions for `amount`, `chainId`, and `tokenAddress` in the documentation.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Buy configuration is now optional in the bridge widget; amount and chain selection can be omitted and will use defaults.
  * Removed forced preset buy values, enabling more flexible initialization.

* **Documentation**
  * Updated docs to reflect optional Buy fields and default behaviors.
  * Revised examples and type descriptions to indicate optional amount and chain settings.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@vercel vercel bot temporarily deployed to Preview – nebula October 6, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 6, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 6, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 6, 2025 19:06 Inactive
@graphite-app graphite-app bot merged commit d9a138a into main Oct 6, 2025
24 checks passed
@graphite-app graphite-app bot deleted the mny-236 branch October 6, 2025 19:11
@vercel vercel bot temporarily deployed to Production – wallet-ui October 6, 2025 19:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 6, 2025 19:11 Inactive
@vercel vercel bot temporarily deployed to Production – nebula October 6, 2025 19:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 6, 2025 19:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants