Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 22, 2025


PR-Codex overview

This PR focuses on enhancing the wallet integration and user interface for the payment system. It introduces new wallet options, refactors components for better usability, and updates the layout for improved responsiveness.

Detailed summary

  • Added createWallet for com.okex.wallet in various components.
  • Created payLandingWallets with multiple wallet options.
  • Refactored PayPage to use StyledBuyWidget and PayLandingHeader.
  • Simplified PayProviders usage in layout.
  • Introduced ToggleThemeButton for theme switching.
  • Added DotsBackgroundPattern for UI enhancement.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Oct 22, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 8d5d3b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2025 21:01 Inactive
@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Oct 22, 2025 10:29pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Oct 22, 2025 10:29pm
nebula Skipped Skipped Oct 22, 2025 10:29pm
thirdweb_playground Skipped Skipped Oct 22, 2025 10:29pm
wallet-ui Skipped Skipped Oct 22, 2025 10:29pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 21:01 Inactive
@MananTank MananTank marked this pull request as ready for review October 22, 2025 21:01
@MananTank MananTank requested review from a team as code owners October 22, 2025 21:01
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mny-243

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

MananTank commented Oct 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 21:05 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 232 ms (+357.42% 🔺) 1.6 s
thirdweb (cjs) 365.82 KB (0%) 7.4 s (0%) 651 ms (+29.98% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 150 ms (+5774.68% 🔺) 265 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 64 ms (+5408.68% 🔺) 74 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 137 ms (+2405.26% 🔺) 519 ms

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.91%. Comparing base (706d696) to head (8d5d3b7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...es/thirdweb/src/react/web/ui/Bridge/FundWallet.tsx 0.00% 14 Missing ⚠️
...ges/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8297      +/-   ##
==========================================
- Coverage   54.92%   54.91%   -0.02%     
==========================================
  Files         919      919              
  Lines       60665    60664       -1     
  Branches     4141     4129      -12     
==========================================
- Hits        33322    33313       -9     
- Misses      27240    27249       +9     
+ Partials      103      102       -1     
Flag Coverage Δ
packages 54.91% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...ges/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx 5.55% <0.00%> (-0.29%) ⬇️
...es/thirdweb/src/react/web/ui/Bridge/FundWallet.tsx 6.22% <0.00%> (-0.02%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2025 21:50 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2025

Merge activity

…verAddress is set (#8296)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview

This PR focuses on modifying the `BuyWidget` component to allow users to bypass wallet connection if a `receiverAddress` is provided. It updates the logic for displaying connection prompts based on the presence of this address.

### Detailed summary

- Updated `BuyWidget` to not require wallet connection if `receiverAddress` is set.
- Removed `activeWalletInfo` dependency from the condition for displaying the `FundWallet`.
- Introduced `showConnectButton` variable to determine if the connect button should be shown.
- Simplified the rendering logic for the connect button in `FundWallet`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview

This PR focuses on enhancing the payment functionalities in the `pay` module by adding new wallet integrations, improving the UI components, and refactoring the `PayPage` logic for better handling of search parameters and rendering.

### Detailed summary

- Added `createWallet` for `com.okex.wallet` in multiple components.
- Introduced `payLandingWallets` with new wallet options.
- Refactored `PayPage` to use `StyledBuyWidget` and `PayLandingHeader`.
- Improved theme toggling with `ToggleThemeButton`.
- Simplified `PayPage` logic for handling search parameters.
- Removed unused imports and components, including `PaymentLinkForm`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 10-23-_mny-286_sdk_do_not_require_connecting_wallet_in_if_is_set branch from 77e1de7 to 49824ce Compare October 22, 2025 22:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 22:20 Inactive
Base automatically changed from 10-23-_mny-286_sdk_do_not_require_connecting_wallet_in_if_is_set to main October 22, 2025 22:39
@joaquim-verges joaquim-verges merged commit 66ae33e into main Oct 22, 2025
22 checks passed
@joaquim-verges joaquim-verges deleted the mny-243 branch October 22, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants