Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2025


PR-Codex overview

This PR introduces a new testnet configuration for the faucet.ts utility by adding support for the Arc testnet alongside the existing Sophon testnet.

Detailed summary

  • Added a comment for the Arc testnet.
  • Introduced a new entry 5042002: 1 for the Arc testnet in the configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added faucet support for the Arc testnet so users on that network can claim test funds.
    • Set the Arc claim amount to 1 for predictable claims on that network.
    • All existing networks and the default claim behavior remain unchanged, preserving current user flows.

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Oct 28, 2025 6:01pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Oct 28, 2025 6:01pm
nebula Skipped Skipped Oct 28, 2025 6:01pm
thirdweb_playground Skipped Skipped Oct 28, 2025 6:01pm
wallet-ui Skipped Skipped Oct 28, 2025 6:01pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: 3d235e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – nebula October 28, 2025 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2025 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2025 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2025 16:33 Inactive
@MananTank MananTank marked this pull request as ready for review October 28, 2025 16:33
@MananTank MananTank requested review from a team as code owners October 28, 2025 16:33
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

Added a new faucet configuration entry for Arc testnet (chainId 5042002) with a claim amount of 1 to the customClaimAmounts mapping in the faucet utilities file.

Changes

Cohort / File(s) Summary
Faucet Configuration
apps/dashboard/src/@/utils/faucet.ts
Added Arc testnet (chainId 5042002) with faucet claim amount 1 to customClaimAmounts mapping

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete. While the author included the template structure with sections for "Notes for the reviewer" and "How to test," neither section contains any substantive information—both are left empty. The description only provides content through the auto-generated PR-Codex overview, which summarizes the change at a high level but does not substitute for the required template sections. The PR lacks critical information such as testing instructions and reviewer notes that are essential for the review process.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Dashboard: Update faucet amount for arc testnet" is well-aligned with the main change in the changeset. It clearly identifies the component being modified (Dashboard), the type of change (updating faucet amount), and the specific scope (Arc testnet). The title is concise, specific, and accurately summarizes the primary modification of adding a new faucet configuration entry for the Arc testnet (chainId 5042002).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-28-dashboard_update_faucet_amount_for_arc_testnet

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.89%. Comparing base (c08fb13) to head (3d235e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8326   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         919      919           
  Lines       60702    60702           
  Branches     4130     4130           
=======================================
  Hits        33321    33321           
  Misses      27279    27279           
  Partials      102      102           
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 157 ms (+245.31% 🔺) 1.5 s
thirdweb (cjs) 366.18 KB (0%) 7.4 s (0%) 567 ms (+18.38% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 80 ms (+2256.7% 🔺) 195 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 67 ms (+3169.31% 🔺) 77 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 69 ms (+2548.97% 🔺) 451 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview

This PR adds a new entry for the `Arc testnet` in the `faucet.ts` file, enhancing the functionality to support an additional test network alongside the existing `Sophon testnet`.

### Detailed summary

- Added a comment for `Arc testnet`.
- Introduced a new entry `5042002: 1` for the `Arc testnet`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **New Features**
  - Introduced faucet support for the Arc testnet, allowing users connected to this network to claim test funds.
  - The claim amount on Arc is set to 1, ensuring consistent and predictable claims on that network.
  - Existing networks and the default claim behavior remain unchanged, preserving current user flows while expanding testnet coverage.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 10-28-dashboard_update_faucet_amount_for_arc_testnet branch from 9482bf4 to 3d235e2 Compare October 28, 2025 17:53
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 28, 2025 17:53 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9482bf4 and 3d235e2.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/utils/faucet.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

  • apps/dashboard/src/@/utils/faucet.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • apps/dashboard/src/@/utils/faucet.ts
apps/{dashboard,playground-web}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Use NavLink for internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Use cn() from @/lib/utils for conditional class logic
Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components (Node edge): Start files with import "server-only";
Client Components (browser): Begin files with 'use client';
Always call getAuthToken() to retrieve JWT from cookies on server side
Use Authorization: Bearer header – never embed tokens in URLs
Return typed results (e.g., Project[], User[]) – avoid any
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stable queryKeys for React Query cache hits
Configure staleTime/cacheTime in React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never import posthog-js in server components

Files:

  • apps/dashboard/src/@/utils/faucet.ts
apps/{dashboard,playground}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/_ (e.g., Button, Input, Tabs, Card)
Use NavLink for internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names with cn() from @/lib/utils for conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start with import "server-only"; use next/headers, server‑only env, heavy data fetching, and redirect() where appropriate
Client Components must start with 'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: call getAuthToken() from cookies, send Authorization: Bearer <token> header, and return typed results (avoid any)
Client-side data fetching: wrap calls in React Query with descriptive, stable queryKeys and set sensible staleTime/cacheTime (≥ 60s default); keep tokens secret via internal routes or server actions
Do not import posthog-js in server components (client-side only)

Files:

  • apps/dashboard/src/@/utils/faucet.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Analyze (javascript)

Comment on lines +8 to +9
// Arc testnet
5042002: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

LGTM! Clean configuration addition.

The Arc testnet entry follows the established pattern and integrates correctly with the existing faucet logic. The claim amount of 1 is reasonable and falls between the default and higher-tier testnets.

Please verify that chain ID 5042002 is the correct identifier for Arc testnet:


🏁 Script executed:

#!/bin/bash
# Description: Verify Arc testnet chain ID via web search or documentation

# Search for Arc testnet chain ID documentation
echo "Please verify the Arc testnet chain ID is 5042002 by checking:"
echo "1. Arc testnet official documentation"
echo "2. ChainList (chainlist.org) or similar chain registry"
echo "3. Arc testnet block explorer"

Length of output: 185


Let me search more specifically for the Arc testnet chain ID configuration:

Critical issue: Arc testnet chain ID is incorrect.

Arc testnet uses chain ID 1244, not 5042002. The current code will not apply the custom claim amount and will default to 0.01 instead of 1. Update line 8 from 5042002 to 1244.

🤖 Prompt for AI Agents
In apps/dashboard/src/@/utils/faucet.ts around lines 8 to 9, the Arc testnet
chain ID is incorrect (currently 5042002) which prevents the custom claim amount
from applying; change the key from 5042002 to 1244 so the Arc testnet maps to
claim amount 1 instead of falling back to 0.01, and ensure the numeric literal
is updated to 1244.

@graphite-app graphite-app bot merged commit 3d235e2 into main Oct 28, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 10-28-dashboard_update_faucet_amount_for_arc_testnet branch October 28, 2025 18:02
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2025 18:02 Inactive
@vercel vercel bot temporarily deployed to Production – nebula October 28, 2025 18:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants