Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2025


PR-Codex overview

This PR focuses on updating the type property of chart components from natural to monotone in various files, likely to improve the visual representation of data in charts.

Detailed summary

  • Updated type from natural to monotone in empty-chart-state.tsx.
  • Updated type from natural to monotone in area-chart.tsx.
  • Updated type from natural to monotone in ErrorRate.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Updated area interpolation to a monotone curve for smoother, more consistent area rendering across charts (including skeleton/placeholder charts).
    • Removed an explicit interpolation override on stacked bars so stacking behavior now follows existing stack settings, improving visual consistency.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: a82a31e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Oct 28, 2025 6:22pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Oct 28, 2025 6:22pm
nebula Skipped Skipped Oct 28, 2025 6:22pm
thirdweb_playground Skipped Skipped Oct 28, 2025 6:22pm
wallet-ui Skipped Skipped Oct 28, 2025 6:22pm

@vercel vercel bot temporarily deployed to Preview – nebula October 28, 2025 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2025 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2025 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2025 18:03 Inactive
@MananTank MananTank marked this pull request as ready for review October 28, 2025 18:03
@MananTank MananTank requested review from a team as code owners October 28, 2025 18:03
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

Updated chart component props: two Area components changed their interpolation type from "natural" to "monotone", and one Bar component had its explicit type="natural" prop removed to rely on default stacking behavior. No other logic or data changes.

Changes

Cohort / File(s) Summary
Area chart interpolation updates
apps/dashboard/src/@/components/analytics/empty-chart-state.tsx, apps/dashboard/src/@/components/blocks/charts/area-chart.tsx
Changed Area component type prop from "natural" to "monotone" for affected series
Bar chart type removal
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(instance)/[engineId]/metrics/components/ErrorRate.tsx
Removed explicit type="natural" prop from Bar component; stacking now determined by stackId/defaults

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Quick property changes across a few components; verify rendering/curve behavior in affected charts.
  • Files to check closely:
    • apps/dashboard/src/@/components/blocks/charts/area-chart.tsx (multiple series behavior)
    • apps/dashboard/src/@/components/analytics/empty-chart-state.tsx (skeleton rendering)
    • apps/dashboard/src/.../ErrorRate.tsx (stacking behavior for bars)

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete and fails to follow the repository's required template format. The author left most template sections as comments without filling them in, including the proper title format "[SDK/Dashboard/Portal] Feature/Fix:", the Linear issue tag (TEAM-0000), meaningful reviewer notes, and testing instructions. The only substantive content is an auto-generated PR-Codex overview that merely summarizes what files were changed without providing context or rationale. Required sections for reviewer guidance and testing are entirely missing. The author should complete the PR description by filling out all required template sections: add the Linear issue tag, provide specific notes for reviewers about why the change from natural to monotone interpolation avoids clipping, include clear testing instructions (e.g., which components to test and how to verify the visual changes), and update the title to follow the format "[Dashboard] Fix: Use monotone curve type for AreaChart to avoid clipping" or similar.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Dashboard: Use monotone curve type for AreaChart to avoid clipping" directly describes the primary change in the changeset. The raw summary confirms that the main changes involve updating interpolation types from "natural" to "monotone" across three chart-related files, with the stated goal of avoiding clipping. The title is specific, clear, and concise without unnecessary noise or generic language, making it easy for reviewers to understand the primary intent of the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-28-dashboard_use_monotone_curve_type_for_areachart_to_avoid_clipping

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b5f30cc and a82a31e.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/components/analytics/empty-chart-state.tsx (1 hunks)
  • apps/dashboard/src/@/components/blocks/charts/area-chart.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(instance)/[engineId]/metrics/components/ErrorRate.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/(instance)/[engineId]/metrics/components/ErrorRate.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/dashboard/src/@/components/blocks/charts/area-chart.tsx
  • apps/dashboard/src/@/components/analytics/empty-chart-state.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.89%. Comparing base (3d235e2) to head (a82a31e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8329   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         919      919           
  Lines       60702    60702           
  Branches     4130     4130           
=======================================
  Hits        33321    33321           
  Misses      27279    27279           
  Partials      102      102           
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 276 ms (+124.35% 🔺) 1.6 s
thirdweb (cjs) 366.18 KB (0%) 7.4 s (0%) 1.2 s (+12.42% 🔺) 8.5 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 157 ms (+1951.58% 🔺) 272 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 88 ms (+3827.39% 🔺) 99 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 150 ms (+2936.05% 🔺) 532 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2025

Merge activity

…8329)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview

This PR focuses on updating the `type` property for charts from `natural` to `monotone` in various components to improve the visual representation of the data.

### Detailed summary

- In `empty-chart-state.tsx`, changed `type` from `natural` to `monotone`.
- In `area-chart.tsx`, changed `type` from `natural` to `monotone`.
- In `ErrorRate.tsx`, changed `type` from `natural` to `monotone`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Style**
  * Updated chart line rendering across multiple dashboard components for improved visual consistency. Area and bar charts now use refined curve interpolation for smoother data visualization.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 10-28-dashboard_use_monotone_curve_type_for_areachart_to_avoid_clipping branch from b5f30cc to a82a31e Compare October 28, 2025 18:14
@vercel vercel bot temporarily deployed to Preview – nebula October 28, 2025 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2025 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2025 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2025 18:14 Inactive
@graphite-app graphite-app bot merged commit a82a31e into main Oct 28, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 10-28-dashboard_use_monotone_curve_type_for_areachart_to_avoid_clipping branch October 28, 2025 18:22
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – nebula October 28, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2025 18:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants