Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 5, 2025


PR-Codex overview

This PR focuses on updating redirect configurations for payment routes in the apps/dashboard directory.

Detailed summary

  • In apps/dashboard/redirects.js:

    • Added a new redirect entry for source: "/payments/x402" to destination: "/x402" with permanent: false.
  • In apps/dashboard/framer-rewrites.js:

    • Removed "/payments/x402" from the rewrites.
    • Added "/x402" to the rewrites.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Updated URL routing structure for payment pages with a redirect to maintain accessibility of the previous path.

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Nov 5, 2025 0:36am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Nov 5, 2025 0:36am
nebula Skipped Skipped Nov 5, 2025 0:36am
thirdweb_playground Skipped Skipped Nov 5, 2025 0:36am
wallet-ui Skipped Skipped Nov 5, 2025 0:36am

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: 6e076e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2025 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2025 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula November 5, 2025 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2025 00:29 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 5, 2025
Copy link
Member Author

jnsdls commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

URL routing configuration is updated across two files. The route "/payments/x402" is removed from the framer-rewrites list and replaced with "/x402", while a corresponding HTTP redirect rule is explicitly added to map the old path to the new one.

Changes

Cohort / Cohort Name Change Summary
Routing Configuration Updates
apps/dashboard/framer-rewrites.js, apps/dashboard/redirects.js
Removed route "/payments/x402" from framer-rewrites array and replaced with "/x402". Added a new non-permanent redirect entry mapping source "/payments/x402" to destination "/x402" in the redirects configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Both changes are straightforward configuration updates with no complex logic
  • Changes are homogeneous (routing/redirect configuration)
  • Single entry modifications across two small files
  • No functional or control-flow logic to validate
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Move_x402_route_from_/payments/x402_to_/x402

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ea4e2fe and 6e076e5.

📒 Files selected for processing (2)
  • apps/dashboard/framer-rewrites.js (1 hunks)
  • apps/dashboard/redirects.js (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jnsdls jnsdls marked this pull request as ready for review November 5, 2025 00:29
@jnsdls jnsdls requested review from a team as code owners November 5, 2025 00:30
@jnsdls jnsdls merged commit b4d365b into main Nov 5, 2025
20 of 22 checks passed
@jnsdls jnsdls deleted the Move_x402_route_from_/payments/x402_to_/x402 branch November 5, 2025 00:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants