-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #8385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8385
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughVersion bumps and changelog updates across the monorepo packages: thirdweb (5.111.8→5.111.9), nebula (0.2.86→0.2.87), wagmi-adapter (0.2.183→0.2.184), and wagmi-demo (0.0.28→0.0.29). Also removes a changeset file. Primary change: Celo Alfajores replaced with celoSepoliaTestnet in thirdweb. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-8: Polish wording + clarify if this is breaking (import rename).
- Capitalize chain names for consistency with prior entries.
- If
celoAlfajoreswas removed/renamed in exports, add a short migration note (users may need to update imports). If it’s still aliased, note that instead to avoid confusion.Suggested edit:
- - [#8384](https://github.com/thirdweb-dev/js/pull/8384) [`673e51b`](https://github.com/thirdweb-dev/js/commit/673e51b11cf2d06f00ab92bd4cbb45c51d95ec1f) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Replace celo alfajores with celoSepoliaTestnet + - [#8384](https://github.com/thirdweb-dev/js/pull/8384) [`673e51b`](https://github.com/thirdweb-dev/js/commit/673e51b11cf2d06f00ab92bd4cbb45c51d95ec1f) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Replace Celo Alfajores with Celo Sepolia Testnet + Note: If you previously imported `celoAlfajores` from `thirdweb/chains`, switch to `celoSepoliaTestnet` (or keep using `celoAlfajores` if it remains as an alias).As per coding guidelines and learnings: surface any breaking changes prominently in the PR/changelog and ensure versioning reflects impact.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/shaky-dragons-check.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/shaky-dragons-check.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.jsonapps/wagmi-demo/package.json
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/thirdweb/CHANGELOG.mdpackages/nebula/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/thirdweb/package.json (1)
433-433: Version bump is correct and properly isolated.The patch version increment to 5.111.9 reflects the celo network update in PR #8384 without affecting the package's API surface.
packages/wagmi-adapter/package.json (1)
59-59: Version bump is correct.Patch increment to 0.2.184 reflects the updated dependency thirdweb@5.111.9, with no API changes.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry for 0.0.29 is complete and accurate.The patch entry correctly documents the updated dependencies and links to the driving commit.
apps/wagmi-demo/package.json (1)
4-4: Version bump is correct and consistent.Patch increment to 0.0.29 properly reflects the dependency updates, with workspace protocol ensuring the demo uses the updated packages.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Minimal changelog entry for 0.2.184 lacks change details.The new version entry is created but contains no details under "Patch Changes". Given that wagmi-demo@0.0.29 (in the same PR) explicitly documents updated dependencies for wagmi-adapter@0.2.184, consider adding a "Updated dependencies" section here for consistency and clarity.
In a changeset release system, this may be expected if no source code changes were made to wagmi-adapter; however, for transparency, it would align better with the pattern used in wagmi-demo/CHANGELOG.md to document the dependency update.
packages/nebula/package.json (1)
60-60: Version bump is correct.Patch increment to 0.2.87 reflects the updated dependency thirdweb@5.111.9, with no API changes.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry for 0.2.87 is complete and accurate.The patch entry properly documents the updated dependency and links to the driving commit, following the established changelog format.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8385 +/- ##
=======================================
Coverage 54.64% 54.64%
=======================================
Files 919 919
Lines 60704 60704
Branches 4112 4112
=======================================
Hits 33171 33171
+ Misses 27432 27431 -1
- Partials 101 102 +1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.87
Patch Changes
673e51b]:thirdweb@5.111.9
Patch Changes
673e51bThanks @joaquim-verges! - Replace celo alfajores with celoSepoliaTestnet@thirdweb-dev/wagmi-adapter@0.2.184
wagmi-inapp@0.0.29
Patch Changes
673e51b]:PR-Codex overview
This PR focuses on version updates across multiple packages, along with corresponding changelog entries that reflect these updates.
Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.111.8to5.111.9.versioninapps/wagmi-demo/package.jsonfrom0.0.28to0.0.29.versioninpackages/nebula/package.jsonfrom0.2.86to0.2.87.versioninpackages/wagmi-adapter/package.jsonfrom0.2.183to0.2.184.packages/nebula/CHANGELOG.mdfor version0.2.87.apps/wagmi-demo/CHANGELOG.mdfor version0.0.29.packages/thirdweb/CHANGELOG.mdfor version5.111.9.Summary by CodeRabbit