Skip to content

Improve Mobile detection in WC connection #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+34 −25
Merged

Improve Mobile detection in WC connection #8415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/thirdweb/src/utils/web/isMobile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
*/
export function isMobile(): boolean {
// Primary signal: OS detection via user agent

const isMobileOS = isAndroid() || isIOS();

if (isMobileOS) {
Expand All @@ -70,5 +71,12 @@
return true;
}

const isMobileViewport =
typeof window !== "undefined" && window.innerWidth < 640;

if (isMobileViewport) {
return true;
}

Check warning on line 79 in packages/thirdweb/src/utils/web/isMobile.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/utils/web/isMobile.ts#L78-L79 

Added lines #L78 - L79 were not covered by tests

return false;
}
51 changes: 26 additions & 25 deletions packages/thirdweb/src/wallets/create-wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,34 +341,35 @@
}
return;
}
// on desktop, create a QR overlay
else {
try {
const { createQROverlay } = await import(
"./wallet-connect/qr-overlay.js"
);

Check warning on line 349 in packages/thirdweb/src/wallets/create-wallet.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/create-wallet.ts#L345-L349 

Added lines #L345 - L349 were not covered by tests

try {
// on desktop, create a QR overlay
const { createQROverlay } = await import(
"./wallet-connect/qr-overlay.js"
);
// Clean up any existing overlay
if (qrOverlay) {
qrOverlay.destroy();
}

Check warning on line 354 in packages/thirdweb/src/wallets/create-wallet.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/create-wallet.ts#L352-L354 

Added lines #L352 - L354 were not covered by tests

// Clean up any existing overlay
if (qrOverlay) {
qrOverlay.destroy();
// Create new QR overlay
qrOverlay = createQROverlay(uri, {
theme:
wcOptions.walletConnect?.qrModalOptions
?.themeMode ?? "dark",
qrSize: 280,
showCloseButton: true,
onCancel: () => {
wcOptions.walletConnect?.onCancel?.();
},
});
} catch (error) {
console.error(
"Failed to create QR overlay:",
error,
);

Check warning on line 371 in packages/thirdweb/src/wallets/create-wallet.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/create-wallet.ts#L357-L371 

Added lines #L357 - L371 were not covered by tests
}

// Create new QR overlay
qrOverlay = createQROverlay(uri, {
theme:
wcOptions.walletConnect?.qrModalOptions
?.themeMode ?? "dark",
qrSize: 280,
showCloseButton: true,
onCancel: () => {
wcOptions.walletConnect?.onCancel?.();
},
});
} catch (error) {
console.error(
"Failed to create QR overlay:",
error,
);
}
}
}),
Expand Down
Loading