-
Notifications
You must be signed in to change notification settings - Fork 627
Version Packages #8470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8470
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughBumps package/app versions across the repo (thirdweb → 5.115.0, nebula → 0.2.97, wagmi-adapter → 0.2.194, wagmi-demo → 0.0.39), removes three changeset files, and adds/updates corresponding CHANGELOG entries mentioning dependency updates and notes about NATIVE_TOKEN_ADDRESS and ERC5792 support. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-8: LGTM; minor polish for readability.Consider code-formatting the constant/function and adding a one-line usage example for readers skimming the changelog.
## 5.114.2 ### Patch Changes -- [#8469](https://github.com/thirdweb-dev/js/pull/8469) [`98d8f29`](https://github.com/thirdweb-dev/js/commit/98d8f292db7f9fd1a80cc67401787da836f24b8e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Allow passing NATIVE_TOKEN_ADDRESS to getWalletBalance() +- [#8469](https://github.com/thirdweb-dev/js/pull/8469) [`98d8f29`](https://github.com/thirdweb-dev/js/commit/98d8f292db7f9fd1a80cc67401787da836f24b8e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Allow passing `NATIVE_TOKEN_ADDRESS` to `getWalletBalance()`. + + ```ts + // Example + const balance = await getWalletBalance({ + address, + tokenAddress: NATIVE_TOKEN_ADDRESS, + }); + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/chatty-rules-listen.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/chatty-rules-listen.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/wagmi-demo/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Run `pnpm changeset` after making changes in `packages/*` for semantic versioning
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Use `patch` version bump for changes that don't impact the public API
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Use `patch` version bump for changes that don't impact the public API
Applied to files:
apps/wagmi-demo/CHANGELOG.mdapps/wagmi-demo/package.jsonpackages/nebula/CHANGELOG.mdpackages/thirdweb/CHANGELOG.md
📚 Learning: 2025-11-24T22:45:01.202Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Applied to files:
apps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.mdpackages/nebula/CHANGELOG.md
📚 Learning: 2025-11-24T22:45:01.202Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything in packages/thirdweb via the exports/ directory, grouped by feature. Every public symbol must have comprehensive TSDoc including at least one example block that compiles and one custom annotation (beta, internal, experimental, etc.)
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in SDK development
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Run `pnpm changeset` after making changes in `packages/*` for semantic versioning
Applied to files:
packages/nebula/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Vercel Agent Review
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/nebula/package.json (1)
60-60: Version bump aligns with PR objectives.Patch version bump (0.2.96 → 0.2.97) is appropriate for dependency updates that don't impact the public API. Consistent with changelog entry and learnings on semantic versioning.
packages/thirdweb/package.json (1)
433-433: Version bump aligns with patch release scope.Patch version bump (5.114.1 → 5.114.2) correctly reflects the non-breaking enhancement enabling NATIVE_TOKEN_ADDRESS support in getWalletBalance(). Consistent with CHANGELOG entry and PR objectives.
apps/wagmi-demo/package.json (1)
4-4: Version bump appropriate for dependency cascade.Patch version bump (0.0.38 → 0.0.39) correctly reflects downstream dependency updates from thirdweb and wagmi-adapter. workspace:* dependency references allow automatic resolution to updated versions. Consistent with CHANGELOG entry.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog structure follows established pattern.Empty version entry for 0.2.194 aligns with existing changelog structure where many intermediate versions lack details. In monorepo releases, dependency-only bumps are documented in dependent packages' changelogs (e.g., wagmi-demo, nebula). This is appropriate for the wagmi-adapter's patch release.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry properly documents dependency cascade.Version 0.0.39 Patch Changes entry correctly lists updated dependencies (thirdweb@5.114.2, wagmi-adapter@0.2.194) with commit reference. Format is consistent with existing entries and clearly communicates the scope of the patch release.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry properly documents dependency update.Version 0.2.97 Patch Changes entry correctly documents the thirdweb@5.114.2 dependency update with consistent commit reference (98d8f29). Format aligns with existing changelog structure and clearly communicates patch scope.
packages/wagmi-adapter/package.json (1)
59-59: Version bump consistent with release scope.Patch version bump (0.2.193 → 0.2.194) is appropriate for this intermediate package in the release cascade. No configuration or public API changes. workspace:* dependency reference allows automatic resolution to updated thirdweb version.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8470 +/- ##
==========================================
- Coverage 54.67% 54.66% -0.01%
==========================================
Files 920 920
Lines 61106 61106
Branches 4143 4143
==========================================
- Hits 33408 33403 -5
- Misses 27596 27601 +5
Partials 102 102
🚀 New features to boost your workflow:
|
size-limit report 📦
|
176ca88 to
f9793ee
Compare
f9793ee to
2bf6a01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
.changeset/chatty-rules-listen.md(0 hunks).changeset/thirty-banks-itch.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/thirty-banks-itch.md
- .changeset/chatty-rules-listen.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/package.json
- packages/thirdweb/CHANGELOG.md
- apps/wagmi-demo/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/wagmi-adapter/package.jsonapps/wagmi-demo/package.jsonpackages/thirdweb/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Vercel Agent Review
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/nebula/CHANGELOG.md (1)
3-8: CHANGELOG entry for 0.2.97 is properly formatted and complete.The patch entry correctly documents the thirdweb@5.115.0 dependency update with three commit references, matching the expected commits from the PR objectives. Format is consistent with previous entries (e.g., 0.2.96).
packages/wagmi-adapter/package.json (1)
59-59: Version bump is correct and peer dependency constraint is satisfied.The patch version update from 0.2.193 → 0.2.194 is appropriate. The peer dependency constraint for thirdweb (^5.85.0) is satisfied by the new thirdweb@5.115.0 release.
packages/thirdweb/package.json (1)
433-433: Minor version bump correctly reflects feature additions.The version update from 5.114.1 → 5.115.0 is semantically appropriate for a minor release introducing new features (ERC-5792 batch transaction support and Bridge API slippage option). The
size-limitpackage is properly configured in devDependencies with the correspondingpnpm sizescript available for bundle size verification.
| "name": "wagmi-inapp", | ||
| "private": true, | ||
| "version": "0.0.38", | ||
| "version": "0.0.39", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version bump from 0.0.38 to 0.0.39 is appropriate for a patch release.
The workspace dependencies (workspace:* references) are correctly formatted and will resolve to their respective workspace package versions during installation. However, verify Biome formatting compliance by running pnpm lint before committing, as required by the coding guidelines for JSON files.
🤖 Prompt for AI Agents
In apps/wagmi-demo/package.json around line 4, the version was bumped to 0.0.39
but the file must comply with Biome/JSON formatting rules enforced by pnpm lint;
run pnpm lint (or biome format) in the repo root, fix any reported JSON
formatting issues, re-run the linter until clean, then stage and commit the
formatted package.json so the version bump passes CI.
2bf6a01 to
42952d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
7-7: Standardize EIP name and punctuation for consistency.Use “EIP-5792” (or “ERC-5792” if that’s your project’s convention) rather than “erc5792”, and consider a semicolon between two clauses:
- “Support EIP-5792 batch transactions for swaps; add slippage option to Bridge API”.
11-15: Reduce perceived redundancy or add context between related bullets.The two bullets about NATIVE_TOKEN_ADDRESS/getWalletBalance read as overlap. Either:
- Merge them into one bullet highlighting the addition and subsequent fix, or
- Append a brief qualifier to the “Fix …” entry (e.g., “Fix getWalletBalance with native token address (edge case X)”) to clarify scope.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (11)
.changeset/chatty-rules-listen.md(0 hunks).changeset/thirty-banks-itch.md(0 hunks).changeset/twelve-grapes-drop.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (3)
- .changeset/twelve-grapes-drop.md
- .changeset/thirty-banks-itch.md
- .changeset/chatty-rules-listen.md
🚧 Files skipped from review as they are similar to previous changes (5)
- apps/wagmi-demo/package.json
- packages/nebula/package.json
- packages/wagmi-adapter/package.json
- apps/wagmi-demo/CHANGELOG.md
- packages/thirdweb/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Vercel Agent Review
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry is correctly formatted.The empty version header for 0.2.194 is appropriate for this release, which contains no direct code changes to the package itself. This follows the established pattern in the changelog for dependency-only releases.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry is well-formed and complete.The version 0.2.97 entry correctly documents the dependency update to thirdweb@5.115.0 with all four relevant commit hashes. The entry follows the established changelog format and accurately reflects the patch release scope.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.115.0
Minor Changes
9e43da4Thanks @joaquim-verges! - Support erc5792 batch transactions for swaps, add slippage option to Bridge APIPatch Changes
#8469
98d8f29Thanks @joaquim-verges! - Allow passing NATIVE_TOKEN_ADDRESS to getWalletBalance()#8486
3ebca18Thanks @joaquim-verges! - Fix getWalletBalance with native token address#8485
4c5696eThanks @joaquim-verges! - Add caching and timeout for fetching capabilities@thirdweb-dev/nebula@0.2.97
Patch Changes
98d8f29,3ebca18,9e43da4,4c5696e]:@thirdweb-dev/wagmi-adapter@0.2.194
wagmi-inapp@0.0.39
Patch Changes
98d8f29,3ebca18,9e43da4,4c5696e]:PR-Codex overview
This PR focuses on updating package versions and changelogs across multiple packages, including
thirdweb,wagmi-demo, andnebula, while also deleting some outdated changelog files.Detailed summary
.changesetfiles.versioninpackages/thirdweb/package.jsonfrom5.114.1to5.115.0.versioninapps/wagmi-demo/package.jsonfrom0.0.38to0.0.39.versioninpackages/nebula/package.jsonfrom0.2.96to0.2.97.versioninpackages/wagmi-adapter/package.jsonfrom0.2.193to0.2.194.packages/nebulaandapps/wagmi-demoreflecting updates to dependencies.packages/thirdwebdetailing minor and patch changes.Summary by CodeRabbit
New Features
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.