Add Solana wallet docs and sidebar link #8489
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
the
Portal
WalkthroughThis PR adds Solana server wallet documentation and a new sidebar link. It introduces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
0xFirekeeper
added
the
merge-queue
Merge activity
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8489 +/- ##
=======================================
Coverage 54.66% 54.66%
=======================================
Files 920 920
Lines 61106 61106
Branches 4143 4143
=======================================
Hits 33403 33403
Misses 27601 27601
Partials 102 102
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/app/wallets/solana/page.mdx (1)
133-139: Consider renaming tab value for consistency.The tab value
"fund"doesn't match the label"2. Check Balance"or the tab content which demonstrates balance checking. Consider renaming to"balance"for clarity:-<Tabs defaultValue="create"> +<Tabs defaultValue="create"> <TabsList> <TabsTrigger value="create">1. Create Wallet</TabsTrigger> - <TabsTrigger value="fund">2. Check Balance</TabsTrigger> + <TabsTrigger value="balance">2. Check Balance</TabsTrigger> <TabsTrigger value="send">3. Send Tokens</TabsTrigger> <TabsTrigger value="swap">4. Swap Tokens</TabsTrigger> </TabsList>And update the corresponding
TabsContent:-<TabsContent value="fund"> +<TabsContent value="balance">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/portal/src/app/wallets/sidebar.tsx(1 hunks)apps/portal/src/app/wallets/solana/page.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoidanyandunknownin TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.) in TypeScript
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose
Files:
apps/portal/src/app/wallets/sidebar.tsx
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/portal/src/app/wallets/sidebar.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Lazy-import optional features; avoid top-level side-effects
Files:
apps/portal/src/app/wallets/sidebar.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Vercel Agent Review
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
apps/portal/src/app/wallets/sidebar.tsx (1)
85-88: LGTM!The new sidebar entry for "Solana Transactions" follows the existing pattern and correctly links to the new documentation page at
/wallets/solana.apps/portal/src/app/wallets/solana/page.mdx (3)
1-21: LGTM!The imports and metadata configuration are well-structured and follow the documentation conventions.
57-127: Well-structured API documentation.The API endpoint sections are comprehensive and logically organized. Good use of callouts to highlight important constraints (funding requirement, mainnet-only swaps).
141-237: LGTM!The example workflow provides practical curl commands with clear request/response pairs. Appropriate use of placeholder secrets (
YOUR_SECRET_KEY) in examples.
size-limit report 📦
|
Added a new sidebar entry for Solana Transactions in the wallets section and introduced a comprehensive Solana server wallet documentation page covering wallet management, balances, transactions, signing, swaps, and example API workflows.
Closes BLD-414
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces support for managing Solana transactions in the application, including wallet creation, balance checking, token transfers, and swaps. It enhances the user interface with detailed documentation and examples for developers.
### Detailed summary
- Added a new sidebar entry for `Solana Transactions`.
- Created a detailed `page.mdx` for Solana server wallets.
- Included metadata for the `Solana Server Wallets` page.
- Documented capabilities: wallet management, balance checking, signing, token swaps, and custom transactions.
- Provided example workflows using `curl` commands for various operations.
- Defined network identifiers for `Mainnet` and `Devnet`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Added Solana Transactions link in Server Wallets navigation for streamlined access to Solana wallet operations
* **Documentation**
* New Solana server wallets documentation page with getting started guides, API workflows for wallet creation, balance retrieval, token transfers, transaction signing, and token swap operations
<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
firekeeper/solana-docs
branch
from
f64e845 to
b27fcd3
Compare
graphite-app
bot
removed
the
merge-queue
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/portal/src/app/wallets/sidebar.tsx (1)
85-88: Consider aligning nav label with page title/scopeThe href correctly matches
/wallets/solana, but the label "Solana Transactions" is narrower than the page’s title/content ("Solana Server Wallets" with management, signing, swaps, etc.). Consider renaming this entry to something like "Solana Server Wallets" for consistency and clearer expectations.apps/portal/src/app/wallets/solana/page.mdx (1)
1-237: Well-structured Solana server wallets doc; only minor optional tweaksThe page is structurally solid: metadata export, sectioning, endpoint references, and tabbed workflow examples all hang together and match the new
/wallets/solanaroute. The curl snippets useYOUR_SECRET_KEYand public Solana addresses/mints, so there are no actual secrets committed—Gitleaks warnings here are false positives.If you want to go a step further, you might add a brief note near the first curl example reminding users not to expose
x-secret-keyin client-side code, but that’s purely an optional hardening/education tweak; the current content is good to ship.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/portal/src/app/wallets/sidebar.tsx(1 hunks)apps/portal/src/app/wallets/solana/page.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoidanyandunknownin TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.) in TypeScript
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose
Files:
apps/portal/src/app/wallets/sidebar.tsx
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/portal/src/app/wallets/sidebar.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Lazy-import optional features; avoid top-level side-effects
Files:
apps/portal/src/app/wallets/sidebar.tsx
🪛 Gitleaks (8.30.0)
apps/portal/src/app/wallets/solana/page.mdx
[high] 143-145: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
[high] 163-164: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
[high] 181-183: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
[high] 203-205: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
[high] 209-209: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Vercel Agent Review
- GitHub Check: Analyze (javascript)
Added a new sidebar entry for Solana Transactions in the wallets section and introduced a comprehensive Solana server wallet documentation page covering wallet management, balances, transactions, signing, swaps, and example API workflows.
Closes BLD-414
PR-Codex overview
This PR focuses on adding support for Solana transactions in the wallet application, including wallet management, transaction capabilities, and detailed API documentation for developers.
Detailed summary
page.mdxfor "Solana Server Wallets" with metadata.Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.