-
-
Notifications
You must be signed in to change notification settings - Fork 12
devDeps: non-breaking bumps of tap, nave #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
828e7e0
to
cd5b087
Compare
Hey I merged the other PRs + published a patch with the changes. |
.addGeneratedMappings('foo.js', foo) | ||
|
||
t.deepEqual( | ||
t.same( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change? deepEqual
should still apply.
Not sure what same
does and had a hard time finding the tap docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tap could indeed use some upgrade notes 😅
same
is a synonym for deepEqual
: https://github.com/tapjs/tapjs/blob/dc56799ec4881d4da239757c16a3c8add683e431/lib/synonyms.js#L25
deepEqual
is deprecated in newer versions: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ff862237bcaf15ba863d7243aed9018b1a90586e/types/tap/index.d.ts#L7
5.4.5 is actually last version to work on node 0.8
cd5b087
to
7eadcab
Compare
Thank you! Conflicts resolved. |
@thlorenz friendly ping :) |
Hey @legobeat thanks for reminding me .. super busy these days, just started a new job and will be traveling last 2 weeks of March. Please merge to master following this guide. Thanks. |
@thlorenz Thank you for the confidence! I'll see how far I progress on my own and the review process is always good but going ahead and merging this for now. Best of luck with work and travels! |
tap
from~0.7.0
to~5.4.5
5.4.5
is actually the latest to still run on node 0.8test.end()
at end of test suites (required for this tap upgrade - should also make it work with newer tap versions like 8+)t.deepEqual
witht.same
nave
from~0.5.0
to^3.5.2
Related