Skip to content

Conversation

legobeat
Copy link
Collaborator

  • Upgrade tap from ~0.7.0 to ~5.4.5
    • 5.4.5 is actually the latest to still run on node 0.8
    • Add test.end() at end of test suites (required for this tap upgrade - should also make it work with newer tap versions like 8+)
    • Replace deprecated t.deepEqual with t.same
  • Upgrade nave from ~0.5.0 to ^3.5.2

Related

@legobeat legobeat marked this pull request as ready for review February 21, 2024 07:45
@legobeat legobeat force-pushed the devdeps-non-breaking branch from 828e7e0 to cd5b087 Compare February 22, 2024 04:50
@thlorenz
Copy link
Owner

Hey I merged the other PRs + published a patch with the changes.
I believe this one would be next to merge. Could you please resolve the conflicts? Then I can merge.

.addGeneratedMappings('foo.js', foo)

t.deepEqual(
t.same(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change? deepEqual should still apply.
Not sure what same does and had a hard time finding the tap docs.

Copy link
Collaborator Author

@legobeat legobeat Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4.5 is actually last version to work on node 0.8
@legobeat legobeat force-pushed the devdeps-non-breaking branch from cd5b087 to 7eadcab Compare February 25, 2024 01:28
@legobeat
Copy link
Collaborator Author

Hey I merged the other PRs + published a patch with the changes. I believe this one would be next to merge. Could you please resolve the conflicts? Then I can merge.

Thank you!

Conflicts resolved.

@legobeat legobeat requested a review from thlorenz February 25, 2024 01:37
@legobeat legobeat mentioned this pull request Feb 25, 2024
3 tasks
@legobeat
Copy link
Collaborator Author

@thlorenz friendly ping :)

@thlorenz
Copy link
Owner

Hey @legobeat thanks for reminding me .. super busy these days, just started a new job and will be traveling last 2 weeks of March.
To get this across the line and since I trust your judgement at this point I made you collaborator.

Please merge to master following this guide.
That guide is a bit old so you can do squash merges from github of course. Plus I already looked at the PRs and they are fine. So adapt + merge what is needed and I will then version and publish to npm.

Thanks.

@legobeat legobeat merged commit d4386cd into thlorenz:master Mar 13, 2024
@legobeat
Copy link
Collaborator Author

@thlorenz Thank you for the confidence! I'll see how far I progress on my own and the review process is always good but going ahead and merging this for now. Best of luck with work and travels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants