-
-
Notifications
You must be signed in to change notification settings - Fork 12
Ensure Node.js >= 10 support #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
219125d
to
ae0a9a6
Compare
076877e
to
0602ed7
Compare
Hey looks good, but please don't check in a package.lock for the following reasons:
People can then lock everything on their app level. |
It actually doesn't under most scenarios for users - lockfiles are disregarded when installing from registry/bundle/git and basically only/mostly used for dev/local build/ci. And when using a differing package manager like yarn/pnpm, IME it's usually a warning, not an error, to have I think there is a lot of value in reproducibility and auditability in checking in the lockfile. But in any case: Lifting it out of scope from this PR. So this PR doesn't include the lockfile addition/ci cache anymore. Also just rebased on |
Check inpackage-lock.json
ci: Enable npm cache of node modulesRelated
package-lock.json
instead ofyarn.lock
Depends on