Skip to content

Conversation

legobeat
Copy link
Collaborator

@legobeat legobeat commented Feb 21, 2024

Related

  • This is broken out from and mostly similar to fix: Buffer warning & update ci #24 except:
    • Maintain compatibility with node v10 (in interest of debian-buster and ubuntu 20.04 lts distro users)
    • package-lock.json instead of yarn.lock
    • Unrelated changes omitted

Depends on

@legobeat legobeat force-pushed the node-10 branch 3 times, most recently from 219125d to ae0a9a6 Compare February 25, 2024 01:34
This was referenced Feb 25, 2024
@legobeat legobeat mentioned this pull request Mar 13, 2024
@legobeat
Copy link
Collaborator Author

legobeat commented Mar 13, 2024

@thlorenz Given that this is a breaking change and there is an unreleased change in the pipe, I'm keeping this and #31 in draft pending release (#32).

@legobeat legobeat force-pushed the node-10 branch 3 times, most recently from 076877e to 0602ed7 Compare March 13, 2024 02:38
@thlorenz
Copy link
Owner

Hey looks good, but please don't check in a package.lock for the following reasons:

  1. don't want to limit peeps to use npm when installing and get different results when using yarn
  2. package lock makes sense for apps not libraries as in a lib we actually do want to get patch updates of the libs we depend on

People can then lock everything on their app level.

@legobeat legobeat mentioned this pull request Sep 19, 2024
@legobeat
Copy link
Collaborator Author

legobeat commented Sep 19, 2024

don't want to limit peeps to use npm when installing and get different results when using yarn

It actually doesn't under most scenarios for users - lockfiles are disregarded when installing from registry/bundle/git and basically only/mostly used for dev/local build/ci. And when using a differing package manager like yarn/pnpm, IME it's usually a warning, not an error, to have package-lock.json present?

I think there is a lot of value in reproducibility and auditability in checking in the lockfile.

But in any case: Lifting it out of scope from this PR. So this PR doesn't include the lockfile addition/ci cache anymore. Also just rebased on master.

@legobeat legobeat marked this pull request as ready for review September 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants