Skip to content

Conversation

noyobo
Copy link

@noyobo noyobo commented Dec 18, 2022

  • node engine >= 12

{"generated":{"line":3,"column":0},"source":"","original":{"line":1,"column":0},"name":null}
@legobeat
Copy link
Collaborator

Addresses #22

@thlorenz Are you still maintaining this package?

Perhaps this PR would benefit from being split into three (CI changes / Buffer deprecation fix / release)

@thlorenz
Copy link
Owner

Yeah I am maintaining it still (very low priority for me though).

As you already pointed out this PR does way too much, and should probably be 3:

  • upgrade deps (and adapt tests to updates)
  • Buffer deprecation fix
  • update CI

Then there are some totally unrelated changes like updates to the .gitignore and an added .npmrc which I wouldn't want in either of those as they don't add any value to the repo IMHO.

So @legobeat if you wanna take on creating some of those I'll be happy to review + merge and publish.

@legobeat
Copy link
Collaborator

legobeat commented Feb 21, 2024

@thlorenz Great, thanks for following up! For now I broke out the Buffer fix into #25. Should be non-breaking.

@legobeat
Copy link
Collaborator

legobeat commented Feb 21, 2024

It became 4:

Independent, apart from #28.

IMO would be nice to release #25 in a 0.6.3 fix before bumping engines.node and 0.7.x (#28).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants