-
-
Notifications
You must be signed in to change notification settings - Fork 12
ci: Migrate from Travis CI to GitHub Actions #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get this in before publishing a new version.
Can you adapt this to pass for now?
Then we publish a patch and afterwards merge the one upgrading node versions (we can drop all below v14.x (given 16 is running out of maintenance).
In order to not make this grow as large as the original #24 , what I did here for now is to disable CI tests on Node >=v10 (which in any case isn't a regression compared to the existing travis config, which never tested that high). IIUC, to make tests properly pass consistently across all currently supported node majors, the sourcemap tests would have to be rewritten to switch expected result depending on major node version (cf https://github.com/thlorenz/inline-source-map/pull/28/files#diff-4a16505372866dba552bc5422181172bacaef66a1c47df075590ac64f1eea4f4L51). Doing that for the sake of transiently passing these ancient node versions doesn't seem worth the effort. |
- ci: Remove Travis CI configuration - ci: Add GitHub Actions workflow testing under node majors 4~20 - chore: Remove `test-all` package script
OK gonna merge this, I saw you disabled newer node versions which should make CI pass right? Also I see those actions are running in your fork, but they aren't here even though I got those enabled. Any idea what I need to do to run those for this PR before I merge it? |
Also thanks for your patience, the main reason I'd like CI to pass is that we're planning to publish a patch for before upgrading Node version requirements and I feel bad doing that with failing CI. |
All good! Actually it turned out that the
|
Only one caveat: See comment above.
Badge in readme has been replaced! preview (that's with #29 applied as well)
The one thing you would need to do would be to enable actions on repo-level, I believe. https://github.com/thlorenz/inline-source-map/settings/actions -> |
test-all
package scriptNote: Modern node version tests fail but this is expected and should be observable if running in Travis or locally as well. The failing node-versions (>=v10) have been disabled for the time being. Not sure if it's worth effort to test 0.6 and 0.8 at this point?